LSP inserts duplicate async keyword #57928
Description
🔎 Search Terms
lsp, intellisense, suggestions, async keyword, autocomplete
🕗 Version & Regression Information
- I was unable to test this on prior versions because I don't have that much time on my hands.
⏯ Playground Link
💻 Code
export interface Foo {
render(value: number, other: string): Promise<string>;
}
class FooImpl implements Foo {
// Type "async render" here and accept suggestion.
// For some reason I cannot reproduce it in the playground,
// but can in vscode with the exact same TS version.
}🙁 Actual behavior
This was originally discovered in denoland/deno#23046 (comment) . We assumed that it is an issue with the TSC fork in Deno's LSP, but turns out that the same issue exists in tsc itself. Best explained via a video:
deno-lsp-async.mp4
🙂 Expected behavior
It should not insert duplicative async keywods:
export interface Foo {
render(value: number, other: string): Promise<string>;
}
class FooImpl implements Foo {
// only one async keyword
async render(value: number, other: string): Promise<string> {
}
}Additional information about the issue
No response