Skip to content

[NewErrors] 5.1.0-dev.20230409 vs 5.0.4 #53713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
typescript-bot opened this issue Apr 9, 2023 · 16 comments
Closed

[NewErrors] 5.1.0-dev.20230409 vs 5.0.4 #53713

typescript-bot opened this issue Apr 9, 2023 · 16 comments
Labels
Committed The team has roadmapped this issue

Comments

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 9, 2023

The following errors were reported by 5.1.0-dev.20230409, but not by 5.0.4
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 200 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 112 of 200 visited repos
Outcome Count
Detected interesting changes 14
Detected no interesting changes 98
Git clone failed 1
Package install failed 25
Project-graph error in old TS 5
Too many errors in old TS 53
Unknown failure 4

Investigation Status

Repo Errors Outcome
angular/angular-cli 6 broken type reference directive (TRD)
BuilderIO/qwik 1 correct new error
compiler-explorer/compiler-explorer 1 broken TRD
discordjs/discord.js 2 This is TS aligning with their existing lint rule (which is disabled on this function instead of just returning, for some reason)
formatjs/formatjs 2 broken (!) by improved subtype merging. Need to write up for blog
infinitered/ignite 1 correct error; not sure how this worked before
microsoft/vscode 2 correct new error (implicit return)
pmndrs/jotai 1
reduxjs/redux 2 Suffered a moved error under ts-expect-error
refined-github/refined-github 1 Correct new error
tldraw/tldraw 7 broken TRD
vuejs/core 2 Suffered a moved error under ts-expect-error
vuetifyjs/vuetify 3 this is a legitimate implicit return
yetone/openai-translator 1 broken TRD
@typescript-bot
Copy link
Collaborator Author

angular/angular-cli

7 of 19 projects failed to build with the old tsc and were ignored

packages/angular_devkit/build_angular/test/hello-world-app/e2e/tsconfig.e2e.json

  • error TS2688: Cannot find type definition file for 'jasmine'.
    • Project Scope
  • error TS2688: Cannot find type definition file for 'node'.
    • Project Scope

packages/angular_devkit/build_angular/test/hello-world-app/src/tsconfig.server.json

  • error TS2688: Cannot find type definition file for '@angular/localize'.
    • Project Scope

packages/angular_devkit/build_angular/test/hello-world-app/src/tsconfig.spec.json

  • error TS2688: Cannot find type definition file for '@angular/localize'.
    • Project Scope
  • error TS2688: Cannot find type definition file for 'jasmine'.
    • Project Scope

packages/angular_devkit/build_angular/test/hello-world-lib/projects/lib/tsconfig.spec.json

  • error TS2688: Cannot find type definition file for 'jasmine'.
    • Project Scope

@typescript-bot
Copy link
Collaborator Author

BuilderIO/qwik

4 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

compiler-explorer/compiler-explorer

3 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2688: Cannot find type definition file for 'chai-http'.
    • Project Scope

@typescript-bot
Copy link
Collaborator Author

discordjs/discord.js

39 of 53 projects failed to build with the old tsc and were ignored

packages/brokers/tsconfig.docs.json

packages/brokers/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

formatjs/formatjs

13 of 34 projects failed to build with the old tsc and were ignored

packages/intl-enumerator/tsconfig.json

packages/intl-segmenter/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

infinitered/ignite

boilerplate/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

microsoft/vscode

6 of 53 projects failed to build with the old tsc and were ignored

extensions/references-view/tsconfig.json

src/tsconfig.tsec.json

@typescript-bot
Copy link
Collaborator Author

pmndrs/jotai

3 of 7 projects failed to build with the old tsc and were ignored

examples/mega-form/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

reduxjs/redux

2 of 5 projects failed to build with the old tsc and were ignored

test/typescript/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

refined-github/refined-github

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

tldraw/tldraw

13 of 20 projects failed to build with the old tsc and were ignored

packages/vec/tsconfig.build.json

packages/vec/tsconfig.dev.json

packages/intersect/tsconfig.build.json

packages/intersect/tsconfig.dev.json

packages/curve/tsconfig.build.json

packages/curve/tsconfig.dev.json

packages/curve/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

vuejs/core

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

@typescript-bot
Copy link
Collaborator Author

vuetifyjs/vuetify

4 of 7 projects failed to build with the old tsc and were ignored

packages/vuetify/tsconfig.checks.json

packages/vuetify/tsconfig.dist.json

packages/vuetify/tsconfig.json

@typescript-bot
Copy link
Collaborator Author

yetone/openai-translator

tsconfig.json

  • error TS2688: Cannot find type definition file for 'sass'.
    • Project Scope

@RyanCavanaugh
Copy link
Member

jotai break bisects to #52106

@RyanCavanaugh
Copy link
Member

The jotai types depend on optics-ts and seem to legitimately just do an enormous type instantiation which was previously incorrect skipped. The repo is not particularly actionable

@RyanCavanaugh RyanCavanaugh added the Committed The team has roadmapped this issue label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Committed The team has roadmapped this issue
Projects
None yet
Development

No branches or pull requests

2 participants