Skip to content

TypeCheckerHost interface should not be exported #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adidahiya opened this issue Aug 17, 2015 · 1 comment
Closed

TypeCheckerHost interface should not be exported #4346

adidahiya opened this issue Aug 17, 2015 · 1 comment
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Help Wanted You can do this
Milestone
TypeScript 1.6

Comments

@adidahiya
Copy link
Contributor

The TypeCheckerHost interface isn't referenced anywhere else in typescriptServices.d.ts. Is this an error? Unlike LanguageService, you can get a TypeChecker with getTypeChecker() on ts.Program. So exposing TypeCheckerHost seems unnecessary.
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this API Relates to the public API for TypeScript labels Aug 18, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Aug 18, 2015

Sounds correct. A PR would be appreciated!

@adidahiya adidahiya changed the title Why is the TypeCheckerHost interface exported? TypeCheckerHost interface should not be exported Aug 18, 2015
@adidahiya adidahiya mentioned this issue Aug 21, 2015
Merged
@mhegazy mhegazy added this to the TypeScript 1.6 milestone Aug 21, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 1.6
Development

No branches or pull requests
2 participants
@adidahiya @mhegazy