Skip to content

notApplicableReason not included in protocol.d.ts #40640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Sep 19, 2020 · 3 comments · Fixed by #40680
Closed

notApplicableReason not included in protocol.d.ts #40640

mjbvz opened this issue Sep 19, 2020 · 3 comments · Fixed by #40680
Assignees
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 19, 2020

Looks like RefactorActionInfo.notApplicableReason never made it into protocol.d.ts. This property does seem to be sent along by the TS Server, it is just the typings for the property that is missing

Confirmed with TS 4.0.3

@DanielRosenwasser DanielRosenwasser added API Relates to the public API for TypeScript Bug A bug in TypeScript labels Sep 21, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.0.4 milestone Sep 21, 2020
@DanielRosenwasser
Copy link
Member

@jessetrinity can you fix this and cherry-pick the changes to release-4.0?

@jessetrinity
Copy link
Contributor

@DanielRosenwasser the only way I can tell how to do this is running gulp LKG. Do I update protocol.ts and run LKG to get the new protocol.d.ts. (along with everything else LKG produces)?

@DanielRosenwasser
Copy link
Member

The LKG can be done prior to the publish - in other words, don't worry about protocol.d.ts, just fix up protocol.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants