Skip to content

All uses of @typedef-defined types are marked deprecated #39466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandersn opened this issue Jul 7, 2020 · 0 comments · Fixed by #39468
Closed

All uses of @typedef-defined types are marked deprecated #39466

sandersn opened this issue Jul 7, 2020 · 0 comments · Fixed by #39468
Assignees
@sandersn
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.0.1

Comments

@sandersn
Copy link
Member

sandersn commented Jul 7, 2020

TypeScript Version: latest

/** @typedef {{ email: string, nickName?: string }} U2 */

/** @type {U2} */
const u2 = { email: "" }

Actual behavior:
U2 in /** @type {U2} */ is marked deprecated.

While I dislike @typedef as much as the next programmer, we shouldn't mark every alias created with it as deprecated.
@sandersn sandersn self-assigned this Jul 7, 2020
@sandersn sandersn added this to the Typescript 4.0.1 milestone Jul 7, 2020
sandersn added a commit that referenced this issue Jul 7, 2020
@sandersn
Mark @typedef as a type declaration
5b3ff4c 
This is only important right now for marking uses of deprecated tags due
to the way that deprecated type references are computed. But I'm
surprised it hasn't caused problems elsewhere.

Fixes #39466
@sandersn sandersn mentioned this issue Jul 7, 2020
Merged
@sandersn sandersn added Bug A bug in TypeScript Fix Available A PR has been opened for this issue labels Jul 7, 2020
sandersn added a commit that referenced this issue Jul 7, 2020
@sandersn
Mark @typedef as a type declaration (#39468)
1814e2a 
* Mark @typedef as a type declaration

This is only important right now for marking uses of deprecated tags due
to the way that deprecated type references are computed. But I'm
surprised it hasn't caused problems elsewhere.

Fixes #39466

* Also mark @callback and @enum

Requires making name lookup in isTypeDeclarationName smarter, but this
is only used by services, so shouldn't be too performance sensitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandersn sandersn

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.0.1
Development

Successfully merging a pull request may close this issue.

Mark @typedef as a type declaration microsoft/TypeScript
1 participant
@sandersn