Skip to content

RTCStatsType in dom.generated.d.ts is incorrect. #36650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
doutori opened this issue Feb 6, 2020 · 3 comments
Closed

RTCStatsType in dom.generated.d.ts is incorrect. #36650

doutori opened this issue Feb 6, 2020 · 3 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone
Backlog

Comments

@doutori
Copy link

doutori commented Feb 6, 2020

TypeScript Version: 3.7.5

Search Terms:

  • RTCStatsType

Code

Expected behavior:

Actual behavior:

RTCStatsType is defined as

https://github.com/microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L20177

Actually returns a hyphenated value.

  • candidate-pair
  • data-channel
  • inbound-rtp
  • local-candidate
  • outbound-rtp
  • remote-candidate

MDN Web Docs -> https://developer.mozilla.org/en-US/docs/Web/API/RTCStatsType

Playground Link:

Related Issues:

@doutori doutori mentioned this issue Feb 6, 2020
Closed
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Feb 6, 2020
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Feb 6, 2020
@ydz-one ydz-one mentioned this issue Feb 14, 2020
Closed
@hikarino-my
Copy link
Contributor

hikarino-my commented Mar 17, 2020 •
edited
Loading

Since these three WebRTC features are published as W3C Candidate Recommendation
https://www.w3.org/TR/webrtc/
https://www.w3.org/TR/webrtc-stats/
https://www.w3.org/TR/webrtc-identity/

I think we should add these types as well.

trptcolin added a commit to trptcolin/TSJS-lib-generator that referenced this issue Sep 23, 2020
@trptcolin
Add WebRTC Stats spec
e23f8f0 
Along other updates, this updates the values in RTCStatsType, which
addresses microsoft/TypeScript#36650
@trptcolin trptcolin mentioned this issue Sep 23, 2020
Merged
@trptcolin
Copy link

I think this is fixed as of #42067

@jakebailey
Copy link
Member

Yes, this was fixed in the above linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Update dom.generated.d.ts doutori/TypeScript
Fix RTCStatsType values ydz-one/TSJS-lib-generator
5 participants
@trptcolin @jakebailey @RyanCavanaugh @doutori @hikarino-my