-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Closed
Labels
BugA bug in TypeScriptA bug in TypeScriptRescheduledThis issue was previously scheduled to an earlier milestoneThis issue was previously scheduled to an earlier milestoneVS Code PriorityCritical issues that VS Code needs fixed in the current TypeScript milestoneCritical issues that VS Code needs fixed in the current TypeScript milestone
Milestone
Description
TypeScript Version: 3.8.0-dev.20191207
Search Terms:
- refactor
- namespace import
- move to new file
Repo
git clone https://github.com/johnpapa/vscode-import-bug.git
- run
npm install
- open
index.ts
- use a quick action to move the
createComment
function to a new file
Bug:
New file is missing an import for Octokit
import { IssuesCreateCommentParams } from '@octokit/rest';
export async function createComment(comment: IssuesCreateCommentParams) {
const octokit = new Octokit({ auth: 'somevalue' });
const response = await octokit.issues.createComment(comment);
return response;
}
In index.ts
, octokit
was imported as a namespace:
import * as Octokit from '@octokit/rest';
Playground Link:
Related Issues:
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptRescheduledThis issue was previously scheduled to an earlier milestoneThis issue was previously scheduled to an earlier milestoneVS Code PriorityCritical issues that VS Code needs fixed in the current TypeScript milestoneCritical issues that VS Code needs fixed in the current TypeScript milestone