Skip to content

'Convert to named parameters' doesn't work with rest parameters of tuple type #30264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabritto opened this issue Mar 7, 2019 · 1 comment
Closed
Assignees
Labels
Bug A bug in TypeScript
Milestone

Comments

@gabritto
Copy link
Member

gabritto commented Mar 7, 2019

Code
Original code:

function fn(a: number, b: number, ...args: [number, number]) { }
fn(1, 2, 3, 4);

Expected behavior:

function fn({ a, b, args }: { a: number; b: number; args: [number, number]; }) { }
fn({ a: 1, b: 2, args: [3, 4] });

Actual behavior:
After refactoring:

function fn({ a, b, args = [] }: { a: number; b: number; args?: [number, number]; }) { }
fn({ a: 1, b: 2, args: [3, 4] });

Related Issues:
#30113

@gabritto gabritto added the Bug A bug in TypeScript label Mar 7, 2019
@gabritto gabritto self-assigned this Mar 7, 2019
@DanielRosenwasser
Copy link
Member

An implementation will probably get it, but it's also worth testing for

function fn(a: number, b: number, ...args: [number, number, ...string[]]) { }
fn(1, 2, 3, 4);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants