Skip to content

TSServer slow when editing a webpacked file #24999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Jun 15, 2018 · 11 comments
Closed

TSServer slow when editing a webpacked file #24999

mjbvz opened this issue Jun 15, 2018 · 11 comments
Assignees
@sandersn @sheetalkamat
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 3.0

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 15, 2018 •
edited
Loading

From microsoft/vscode#51361

TypeScript Version: 3.0.0-dev.20180609

Search Terms:

Code
Open this file in VS Code: index.js.txt

Bug:
Intellisense stops working properly

Possible root cause is a getJSDocTags:

Err 463   [11:54:25.865] Exception on executing command delayed processing of request 15:

    Debug Failure. False expression.

    Error: Debug Failure. False expression.
    at getJSDocTags (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:11705:22)
    at getFirstJSDocTag (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:11712:24)
    at Object.getJSDocType (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:11689:19)
    at getContextualSignature (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:35577:32)
    at checkFunctionExpressionOrObjectLiteralMethod (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:38366:43)
    at checkExpressionWorker (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39292:28)
    at checkExpression (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39225:42)
    at checkBinaryLikeExpression (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:38839:29)
    at checkBinaryExpression (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:38831:20)
    at checkExpressionWorker (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39313:28)
    at checkExpression (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39225:42)
    at checkExpressionCached (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39111:38)
    at getTypeOfExpression (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39207:28)
    at checkDeclarationInitializer (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:39122:24)
    at getTypeForVariableLikeDeclaration (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:26638:28)
    at getWidenedTypeForVariableLikeDeclaration (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:26829:24)
    at getTypeOfVariableOrParameterOrProperty (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:26918:28)
    at getTypeOfSymbol (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:27103:24)
    at checkVariableLikeDeclaration (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:41092:41)
    at checkVariableDeclaration (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:41149:20)
    at checkSourceElement (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:42841:28)
    at Object.forEach (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:1541:30)
    at checkVariableStatement (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:41158:16)
    at checkSourceElement (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:42810:28)
    at Object.forEach (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:1541:30)
    at checkBlock (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:40853:20)
    at checkSourceElement (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:42808:28)
    at checkFunctionExpressionOrObjectLiteralMethodDeferred (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:38409:21)
    at checkDeferredNodes (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:42935:25)
    at checkSourceFileWorker (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:42977:17)
    at checkSourceFile (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:42949:13)
    at Object.getSuggestionDiagnostics (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:23134:21)
    at /Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:65776:61
    at runWithCancellationToken (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:65732:24)
    at Object.getSuggestionDiagnostics (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:65775:20)
    at Object.computeSuggestionDiagnostics (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:80302:36)
    at Object.getSuggestionDiagnostics (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:90856:23)
    at IOSession.Session.suggestionCheck (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:96975:87)
    at /Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:97020:39
    at MultistepOperation.executeAction (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:96480:25)
    at /Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:96461:100
    at IOSession.Session.executeWithRequestId (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:98117:28)
    at Object.executeWithRequestId (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:96846:87)
    at Immediate.<anonymous> (/Users/matb/Downloads/interface-example/node_modules/typescript/lib/tsserver.js:96461:41)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Jun 15, 2018
@sheetalkamat
Copy link
Member

@sandersn can you please take a look

@sandersn
Copy link
Member

#24973 should have fixed this yesterday.

However, I can't get this assert to repro to confirm whether it's fixed. @mjbvz do you mind trying with a newer build of typescript? We don't have an up-to-date typescript@next, but I can update this issue when we fix that problem.

@mjbvz mjbvz mentioned this issue Jun 15, 2018
Closed
@mjbvz
Copy link
Contributor Author

mjbvz commented Jun 15, 2018

Thanks @sandersn. I just tested the latest build from master and no longer see that error but the problem still exists. There is now this debug failure followed by a huge navtree that seems to contain a cycle or something:

Err 358   [14:21:43.969] Exception on executing command delayed processing of request 54:

    Debug Failure. False expression.

    Error: Debug Failure. False expression.
    at mergeSymbol (/Users/matb/projects/TypeScript/built/local/tsserver.js:29853:26)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:29914:49
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (/Users/matb/projects/TypeScript/built/local/tsserver.js:29913:20)
    at mergeModuleAugmentation (/Users/matb/projects/TypeScript/built/local/tsserver.js:29927:17)
    at initializeTypeChecker (/Users/matb/projects/TypeScript/built/local/tsserver.js:53877:25)
    at Object.createTypeChecker (/Users/matb/projects/TypeScript/built/local/tsserver.js:29585:9)
    at getDiagnosticsProducingTypeChecker (/Users/matb/projects/TypeScript/built/local/tsserver.js:82051:93)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:82182:35
    at runWithCancellationToken (/Users/matb/projects/TypeScript/built/local/tsserver.js:82152:24)
    at getSemanticDiagnosticsForFileNoCache (/Users/matb/projects/TypeScript/built/local/tsserver.js:82175:20)
    at getAndCacheDiagnostics (/Users/matb/projects/TypeScript/built/local/tsserver.js:82426:26)
    at getSemanticDiagnosticsForFile (/Users/matb/projects/TypeScript/built/local/tsserver.js:82172:20)
    at getDiagnosticsHelper (/Users/matb/projects/TypeScript/built/local/tsserver.js:82114:24)
    at Object.getSemanticDiagnostics (/Users/matb/projects/TypeScript/built/local/tsserver.js:82127:20)
    at Object.getSemanticDiagnostics (/Users/matb/projects/TypeScript/built/local/tsserver.js:109488:47)
    at IOSession.Session.semanticCheck (/Users/matb/projects/TypeScript/built/local/tsserver.js:116385:52)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:116424:31
    at MultistepOperation.executeAction (/Users/matb/projects/TypeScript/built/local/tsserver.js:115897:25)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:115878:100
    at IOSession.Session.executeWithRequestId (/Users/matb/projects/TypeScript/built/local/tsserver.js:117537:28)
    at Object.executeWithRequestId (/Users/matb/projects/TypeScript/built/local/tsserver.js:116263:87)
    at Immediate.<anonymous> (/Users/matb/projects/TypeScript/built/local/tsserver.js:115878:41)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)
Info 359  [14:21:43.969] event:
    {"seq":0,"type":"event","event":"requestCompleted","body":{"request_seq":54}}
Info 360  [14:21:44.527] request:
    {"seq":55,"type":"request","command":"geterr","arguments":{"delay":0,"files":["/Users/matb/projects/san/index.js","/users/matb/projects/san/index.js","/users/matb/projects/san/b.js"]}}
Perf 361  [14:21:44.528] 55::geterr: async elapsed time (in milliseconds) 0.4976
Info 362  [14:21:44.529] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 363  [14:21:44.529] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 5 structureChanged: false Elapsed: 0ms
Info 364  [14:21:44.529] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 365  [14:21:44.529] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 5 structureChanged: false Elapsed: 0ms
Info 366  [14:21:44.530] event:
    {"seq":0,"type":"event","event":"syntaxDiag","body":{"file":"/Users/matb/projects/san/index.js","diagnostics":[]}}
Info 367  [14:21:44.530] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 368  [14:21:44.530] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 5 structureChanged: false Elapsed: 0ms
Info 369  [14:21:44.530] Starting updateGraphWorker: Project: /dev/null/inferredProject1*
Info 370  [14:21:44.530] Finishing updateGraphWorker: Project: /dev/null/inferredProject1* Version: 5 structureChanged: false Elapsed: 0ms
Err 371   [14:21:44.532] Exception on executing command delayed processing of request 55:

    Debug Failure. False expression.

    Error: Debug Failure. False expression.
    at mergeSymbol (/Users/matb/projects/TypeScript/built/local/tsserver.js:29853:26)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:29914:49
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (/Users/matb/projects/TypeScript/built/local/tsserver.js:29913:20)
    at mergeModuleAugmentation (/Users/matb/projects/TypeScript/built/local/tsserver.js:29927:17)
    at initializeTypeChecker (/Users/matb/projects/TypeScript/built/local/tsserver.js:53877:25)
    at Object.createTypeChecker (/Users/matb/projects/TypeScript/built/local/tsserver.js:29585:9)
    at getDiagnosticsProducingTypeChecker (/Users/matb/projects/TypeScript/built/local/tsserver.js:82051:93)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:82182:35
    at runWithCancellationToken (/Users/matb/projects/TypeScript/built/local/tsserver.js:82152:24)
    at getSemanticDiagnosticsForFileNoCache (/Users/matb/projects/TypeScript/built/local/tsserver.js:82175:20)
    at getAndCacheDiagnostics (/Users/matb/projects/TypeScript/built/local/tsserver.js:82426:26)
    at getSemanticDiagnosticsForFile (/Users/matb/projects/TypeScript/built/local/tsserver.js:82172:20)
    at getDiagnosticsHelper (/Users/matb/projects/TypeScript/built/local/tsserver.js:82114:24)
    at Object.getSemanticDiagnostics (/Users/matb/projects/TypeScript/built/local/tsserver.js:82127:20)
    at Object.getSemanticDiagnostics (/Users/matb/projects/TypeScript/built/local/tsserver.js:109488:47)
    at IOSession.Session.semanticCheck (/Users/matb/projects/TypeScript/built/local/tsserver.js:116385:52)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:116424:31
    at MultistepOperation.executeAction (/Users/matb/projects/TypeScript/built/local/tsserver.js:115897:25)
    at /Users/matb/projects/TypeScript/built/local/tsserver.js:115878:100
    at IOSession.Session.executeWithRequestId (/Users/matb/projects/TypeScript/built/local/tsserver.js:117537:28)
    at Object.executeWithRequestId (/Users/matb/projects/TypeScript/built/local/tsserver.js:116263:87)
    at Immediate.<anonymous> (/Users/matb/projects/TypeScript/built/local/tsserver.js:115878:41)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)
Info 372  [14:21:44.533] event:
    {"seq":0,"type":"event","event":"requestCompleted","body":{"request_seq":55}}
Info 373  [14:21:46.228] DirectoryWatcher:: Triggered with /Users/matb/projects/san/.git/index.lock:: WatchInfo: /Users/matb/projects/san 1 Project: /dev/null/inferredProject1* WatchType: Directory of Failed lookup locations in module resolution
Info 374  [14:21:46.228] Elapsed:: 0ms DirectoryWatcher:: Triggered with /Users/matb/projects/san/.git/index.lock:: WatchInfo: /Users/matb/projects/san 1 Project: /dev/null/inferredProject1* WatchType: Directory of Failed lookup locations in module resolution
Info 375  [14:21:46.278] DirectoryWatcher:: Triggered with /Users/matb/projects/san/.git/index.lock:: WatchInfo: /Users/matb/projects/san 1 Project: /dev/null/inferredProject1* WatchType: Directory of Failed lookup locations in module resolution
Info 376  [14:21:46.278] Elapsed:: 0ms DirectoryWatcher:: Triggered with /Users/matb/projects/san/.git/index.lock:: WatchInfo: /Users/matb/projects/san 1 Project: /dev/null/inferredProject1* WatchType: Directory of Failed lookup locations in module resolution
Info 377  [14:21:47.375] request:
    {"seq":56,"type":"request","command":"navtree","arguments":{"file":"/Users/matb/projects/san/b.js"}}
Perf 378  [14:21:47.938] 56::navtree: elapsed time (in milliseconds) 562.9710
Info 379  [14:21:48.101] response:
    {"seq":0,"type":"response","command":"navtree","request_seq":56,"success":true,"body":{"text":"<global>","kind":"script","kindModifiers":"","spans":[{"start":{"line":1,"offset":1},"end":{"line":1279,"offset":2}}],"childItems":[{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":10,"offset":12},"end":{"line":1276,"offset":2}}],"childItems":[{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":588,"offset":8},"end":{"line":593,"offset":2}}],"childItems":[{"text":"<unknown>","kind":"const","kindModifiers":"","spans":[{"start":{"line":590,"offset":17},"end":{"line":590,"offset":65}}]}]},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":11,"offset":22},"end":{"line":89,"offset":2}}],"childItems":[{"text":"__webpack_require__","kind":"function","kindModifiers":"","spans":[{"start":{"line":16,"offset":11},"end":{"line":40,"offset":2}}],"nameSpan":{"start":{"line":16,"offset":20},"end":{"line":16,"offset":39}},"childItems":[{"text":"module","kind":"var","kindModifiers":"","spans":[{"start":{"line":24,"offset":16},"end":{"line":29,"offset":2}}],"nameSpan":{"start":{"line":24,"offset":16},"end":{"line":24,"offset":22}}}]},{"text":"d","kind":"function","kindModifiers":"","spans":[{"start":{"line":50,"offset":35},"end":{"line":61,"offset":2}}],"nameSpan":{"start":{"line":50,"offset":31},"end":{"line":50,"offset":32}}},{"text":"installedModules","kind":"var","kindModifiers":"","spans":[{"start":{"line":13,"offset":15},"end":{"line":13,"offset":36}}],"nameSpan":{"start":{"line":13,"offset":15},"end":{"line":13,"offset":31}}},{"text":"n","kind":"function","kindModifiers":"","spans":[{"start":{"line":70,"offset":35},"end":{"line":77,"offset":2}}],"nameSpan":{"start":{"line":70,"offset":31},"end":{"line":70,"offset":32}},"childItems":[{"text":"getter","kind":"var","kindModifiers":"","spans":[{"start":{"line":71,"offset":16},"end":{"line":73,"offset":59}}],"nameSpan":{"start":{"line":71,"offset":16},"end":{"line":71,"offset":22}},"childItems":[{"text":"getDefault","kind":"function","kindModifiers":"","spans":[{"start":{"line":72,"offset":13},"end":{"line":72,"offset":64}}],"nameSpan":{"start":{"line":72,"offset":22},"end":{"line":72,"offset":32}}},{"text":"getModuleExports","kind":"function","kindModifiers":"","spans":[{"start":{"line":73,"offset":13},"end":{"line":73,"offset":59}}],"nameSpan":{"start":{"line":73,"offset":22},"end":{"line":73,"offset":38}}}]}]},{"text":"o","kind":"function","kindModifiers":"","spans":[{"start":{"line":80,"offset":35},"end":{"line":80,"offset":129}}],"nameSpan":{"start":{"line":80,"offset":31},"end":{"line":80,"offset":32}}},{"text":"r","kind":"function","kindModifiers":"","spans":[{"start":{"line":64,"offset":35},"end":{"line":67,"offset":2}}],"nameSpan":{"start":{"line":64,"offset":31},"end":{"line":64,"offset":32}}}]},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":100,"offset":8},"end":{"line":105,"offset":2}}],"childItems":[{"text":"<unknown>","kind":"const","kindModifiers":"","spans":[{"start":{"line":102,"offset":17},"end":{"line":102,"offset":64}}]}]},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":108,"offset":8},"end":{"line":113,"offset":2}}],"childItems":[{"text":"<unknown>","kind":"const","kindModifiers":"","spans":[{"start":{"line":110,"offset":17},"end":{"line":110,"offset":64}}]}]},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":116,"offset":8},"end":{"line":121,"offset":2}}],"childItems":[{"text":"<unknown>","kind":"const","kindModifiers":"","spans":[{"start":{"line":118,"offset":17},"end":{"line":118,"offset":64}}]}]},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":123,"offset":8},"end":{"line":444,"offset":2}}],"childItems":[{"text":"_interopRequireDefault","kind":"function","kindModifiers":"","spans":[{"start":{"line":159,"offset":17},"end":{"line":159,"offset":112}}],"nameSpan":{"start":{"line":159,"offset":26},"end":{"line":159,"offset":48}}},{"text":"_nodeQsSerialization","kind":"var","kindModifiers":"","spans":[{"start":{"line":147,"offset":21},"end":{"line":147,"offset":67}}],"nameSpan":{"start":{"line":147,"offset":21},"end":{"line":147,"offset":41}}},{"text":"_parseQuery","kind":"var","kindModifiers":"","spans":[{"start":{"line":155,"offset":21},"end":{"line":155,"offset":58}}],"nameSpan":{"start":{"line":155,"offset":21},"end":{"line":155,"offset":32}}},{"text":"_parseQuery2","kind":"var","kindModifiers":"","spans":[{"start":{"line":157,"offset":21},"end":{"line":157,"offset":71}}],"nameSpan":{"start":{"line":157,"offset":21},"end":{"line":157,"offset":33}}},{"text":"_reactRouter","kind":"var","kindModifiers":"","spans":[{"start":{"line":153,"offset":21},"end":{"line":153,"offset":59}}],"nameSpan":{"start":{"line":153,"offset":21},"end":{"line":153,"offset":33}}},{"text":"_typeof","kind":"var","kindModifiers":"","spans":[{"start":{"line":133,"offset":21},"end":{"line":133,"offset":285}}],"nameSpan":{"start":{"line":133,"offset":21},"end":{"line":133,"offset":28}},"childItems":[{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":133,"offset":101},"end":{"line":133,"offset":138}}]},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":133,"offset":141},"end":{"line":133,"offset":285}}]}]},{"text":"_underscore","kind":"var","kindModifiers":"","spans":[{"start":{"line":145,"offset":21},"end":{"line":145,"offset":57}}],"nameSpan":{"start":{"line":145,"offset":21},"end":{"line":145,"offset":32}}},{"text":"_urijs","kind":"var","kindModifiers":"","spans":[{"start":{"line":149,"offset":21},"end":{"line":149,"offset":53}}],"nameSpan":{"start":{"line":149,"offset":21},"end":{"line":149,"offset":27}}},{"text":"_urijs2","kind":"var","kindModifiers":"","spans":[{"start":{"line":151,"offset":21},"end":{"line":151,"offset":61}}],"nameSpan":{"start":{"line":151,"offset":21},"end":{"line":151,"offset":28}}},{"text":"blacklistQueryParameterCoercion","kind":"const","kindModifiers":"","spans":[{"start":{"line":136,"offset":17},"end":{"line":136,"offset":90}}],"nameSpan":{"start":{"line":136,"offset":25},"end":{"line":136,"offset":56}}},{"text":"blacklistQueryParameterCoercion","kind":"function","kindModifiers":"","spans":[{"start":{"line":189,"offset":17},"end":{"line":199,"offset":18}}],"nameSpan":{"start":{"line":189,"offset":26},"end":{"line":189,"offset":57}},"childItems":[{"text":"_key","kind":"var","kindModifiers":"","spans":[{"start":{"line":190,"offset":81},"end":{"line":190,"offset":89}}],"nameSpan":{"start":{"line":190,"offset":81},"end":{"line":190,"offset":85}}},{"text":"_len","kind":"var","kindModifiers":"","spans":[{"start":{"line":190,"offset":30},"end":{"line":190,"offset":53}}],"nameSpan":{"start":{"line":190,"offset":30},"end":{"line":190,"offset":34}}},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":194,"offset":40},"end":{"line":198,"offset":22}}]},{"text":"parameters","kind":"var","kindModifiers":"","spans":[{"start":{"line":190,"offset":55},"end":{"line":190,"offset":79}}],"nameSpan":{"start":{"line":190,"offset":55},"end":{"line":190,"offset":65}}}]},{"text":"buildSearch","kind":"const","kindModifiers":"","spans":[{"start":{"line":137,"offset":17},"end":{"line":137,"offset":50}}],"nameSpan":{"start":{"line":137,"offset":25},"end":{"line":137,"offset":36}}},{"text":"buildSearch","kind":"function","kindModifiers":"","spans":[{"start":{"line":222,"offset":17},"end":{"line":224,"offset":18}}],"nameSpan":{"start":{"line":222,"offset":26},"end":{"line":222,"offset":37}}},{"text":"buildTargetLocation","kind":"const","kindModifiers":"","spans":[{"start":{"line":142,"offset":17},"end":{"line":142,"offset":66}}],"nameSpan":{"start":{"line":142,"offset":25},"end":{"line":142,"offset":44}}},{"text":"buildTargetLocation","kind":"function","kindModifiers":"","spans":[{"start":{"line":349,"offset":17},"end":{"line":379,"offset":18}}],"nameSpan":{"start":{"line":349,"offset":26},"end":{"line":349,"offset":45}},"childItems":[{"text":"_mergeQueryParameters","kind":"var","kindModifiers":"","spans":[{"start":{"line":374,"offset":25},"end":{"line":374,"offset":146}}],"nameSpan":{"start":{"line":374,"offset":25},"end":{"line":374,"offset":46}}},{"text":"_ref2$coerceTypes","kind":"var","kindModifiers":"","spans":[{"start":{"line":352,"offset":25},"end":{"line":352,"offset":62}}],"nameSpan":{"start":{"line":352,"offset":25},"end":{"line":352,"offset":42}}},{"text":"_ref2$replaceQuery","kind":"var","kindModifiers":"","spans":[{"start":{"line":354,"offset":25},"end":{"line":354,"offset":64}}],"nameSpan":{"start":{"line":354,"offset":25},"end":{"line":354,"offset":43}}},{"text":"_target","kind":"var","kindModifiers":"","spans":[{"start":{"line":361,"offset":29},"end":{"line":361,"offset":131}}],"nameSpan":{"start":{"line":361,"offset":29},"end":{"line":361,"offset":36}}},{"text":"_URI$parse","kind":"var","kindModifiers":"","spans":[{"start":{"line":367,"offset":29},"end":{"line":367,"offset":81}}],"nameSpan":{"start":{"line":367,"offset":29},"end":{"line":367,"offset":39}}},{"text":"coerceTypes","kind":"var","kindModifiers":"","spans":[{"start":{"line":353,"offset":25},"end":{"line":353,"offset":97}}],"nameSpan":{"start":{"line":353,"offset":25},"end":{"line":353,"offset":36}}},{"text":"exact","kind":"var","kindModifiers":"","spans":[{"start":{"line":356,"offset":25},"end":{"line":356,"offset":44}}],"nameSpan":{"start":{"line":356,"offset":25},"end":{"line":356,"offset":30}}},{"text":"location","kind":"var","kindModifiers":"","spans":[{"start":{"line":351,"offset":25},"end":{"line":351,"offset":50}}],"nameSpan":{"start":{"line":351,"offset":25},"end":{"line":351,"offset":33}}},{"text":"path","kind":"var","kindModifiers":"","spans":[{"start":{"line":368,"offset":29},"end":{"line":368,"offset":51}}],"nameSpan":{"start":{"line":368,"offset":29},"end":{"line":368,"offset":33}}},{"text":"preservedQueryParameters","kind":"var","kindModifiers":"","spans":[{"start":{"line":357,"offset":25},"end":{"line":357,"offset":82}}],"nameSpan":{"start":{"line":357,"offset":25},"end":{"line":357,"offset":49}}},{"text":"query","kind":"var","kindModifiers":"","spans":[{"start":{"line":369,"offset":29},"end":{"line":369,"offset":53}}],"nameSpan":{"start":{"line":369,"offset":29},"end":{"line":369,"offset":34}}},{"text":"replaceQuery","kind":"var","kindModifiers":"","spans":[{"start":{"line":355,"offset":25},"end":{"line":355,"offset":101}}],"nameSpan":{"start":{"line":355,"offset":25},"end":{"line":355,"offset":37}}},{"text":"search","kind":"var","kindModifiers":"","spans":[{"start":{"line":375,"offset":25},"end":{"line":375,"offset":62}}],"nameSpan":{"start":{"line":375,"offset":25},"end":{"line":375,"offset":31}}},{"text":"target","kind":"var","kindModifiers":"","spans":[{"start":{"line":377,"offset":25},"end":{"line":377,"offset":143}}],"nameSpan":{"start":{"line":377,"offset":25},"end":{"line":377,"offset":31}}},{"text":"targetDescriptor","kind":"var","kindModifiers":"","spans":[{"start":{"line":350,"offset":25},"end":{"line":350,"offset":52}}],"nameSpan":{"start":{"line":350,"offset":25},"end":{"line":350,"offset":41}}},{"text":"targetLocation","kind":"var","kindModifiers":"","spans":[{"start":{"line":365,"offset":25},"end":{"line":365,"offset":58}}],"nameSpan":{"start":{"line":365,"offset":25},"end":{"line":365,"offset":39}}}]},{"text":"coalesce","kind":"const","kindModifiers":"","spans":[{"start":{"line":131,"offset":17},"end":{"line":131,"offset":63}}],"nameSpan":{"start":{"line":131,"offset":25},"end":{"line":131,"offset":33}},"childItems":[{"text":"deparam","kind":"const","kindModifiers":"","spans":[{"start":{"line":131,"offset":36},"end":{"line":131,"offset":63}}],"nameSpan":{"start":{"line":131,"offset":44},"end":{"line":131,"offset":51}}}]},{"text":"coalesce","kind":"var","kindModifiers":"","spans":[{"start":{"line":324,"offset":21},"end":{"line":332,"offset":18}}],"nameSpan":{"start":{"line":324,"offset":21},"end":{"line":324,"offset":29}},"childItems":[{"text":"coalesce","kind":"function","kindModifiers":"","spans":[{"start":{"line":324,"offset":51},"end":{"line":332,"offset":18}}],"nameSpan":{"start":{"line":324,"offset":60},"end":{"line":324,"offset":68}},"childItems":[{"text":"_key2","kind":"var","kindModifiers":"","spans":[{"start":{"line":325,"offset":77},"end":{"line":325,"offset":86}}],"nameSpan":{"start":{"line":325,"offset":77},"end":{"line":325,"offset":82}}},{"text":"_len2","kind":"var","kindModifiers":"","spans":[{"start":{"line":325,"offset":30},"end":{"line":325,"offset":54}}],"nameSpan":{"start":{"line":325,"offset":30},"end":{"line":325,"offset":35}}},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":329,"offset":38},"end":{"line":331,"offset":22}}]},{"text":"args","kind":"var","kindModifiers":"","spans":[{"start":{"line":325,"offset":56},"end":{"line":325,"offset":75}}],"nameSpan":{"start":{"line":325,"offset":56},"end":{"line":325,"offset":60}}}]},{"text":"coalesce","kind":"function","kindModifiers":"","spans":[{"start":{"line":324,"offset":32},"end":{"line":332,"offset":18}}],"nameSpan":{"start":{"line":324,"offset":40},"end":{"line":324,"offset":48}},"childItems":[{"text":"coalesce","kind":"function","kindModifiers":"","spans":[{"start":{"line":324,"offset":51},"end":{"line":332,"offset":18}}],"nameSpan":{"start":{"line":324,"offset":60},"end":{"line":324,"offset":68}},"childItems":[{"text":"_key2","kind":"var","kindModifiers":"","spans":[{"start":{"line":325,"offset":77},"end":{"line":325,"offset":86}}],"nameSpan":{"start":{"line":325,"offset":77},"end":{"line":325,"offset":82}}},{"text":"_len2","kind":"var","kindModifiers":"","spans":[{"start":{"line":325,"offset":30},"end":{"line":325,"offset":54}}],"nameSpan":{"start":{"line":325,"offset":30},"end":{"line":325,"offset":35}}},{"text":"<function>","kind":"function","kindModifiers":"","spans":[{"start":{"line":329,"offset":38},"end":{"line":331,"offset":22}}]},{"text":"args","kind":"var","kindModifiers":"","spans":[{"start":{"line":325,"offset":56},"end":{"line":325,"offset":75}}],"nameSpan":{"start":{"line":325,"offset":56},"end":{"line":325,"offset":60}}}]}]}]},{"text":"coercionBlacklist","kind":"var","kindModifiers":"","spans":[{"start":{"line":183,"offset":21},"end":{"line":183,"offset":43}}],"nameSpan":{"start":{"line":183,"offset":21},"end":{"line":183,"offset":38}}},{"text":"createURIFromLocation","kind":"const","kindModifiers":"","spans":[{"start":{"line":138,"offset":17},"end":{"line":138,"offset":70}}],"nameSpan":{"start":{"line":138,"offset":25},"end":{"line":138,"offset":46}}},{"text":"createURIFromLocation","kind":"function","kindModifiers":"","spans":[{"start":{"line":231,"offset":17},"end":{"line":253,"offset":18}}],"nameSpan":{"start":{"line":231,"offset":26},"end":{"line":231,"offset":47}},"childItems":[{"text":"pathname","kind":"var","kindModifiers":"","spans":[{"start":{"line":236,"offset":25},"end":{"line":236,"offset":53}}],"nameSpan":{"start":{"line":236,"offset":25},"end":{"line":236,"offset":33}}},{"text":"search","kind":"var","kindModifiers":"","spans":[{"start":{"line":237,"offset":25},"end":{"line":237,"offset":49}}],"nameSpan":{"start":{"line":237,"offset":25},"end":{"line":237,"offset":31}}},{"text":"uri","kind":"var","kindModifiers":"","spans":[{"start":{"line":239,"offset":25},"end":{"line":239,"offset":54}}],"nameSpan":{"start":{"line":239,"offset":25},"end":{"line":239,"offset":28}}}]},{"text":"deparam","kind":"const","kindModifiers":"","spans":[{"start":{"line":131,"offset":36},"end":{"line":131,"offset":63}}],"nameSpan":{"start":{"line":131,"offset":44},"end":{"line":131,"offset":51}}},{"text":"deparam","kind":"var","kindModifiers":"","spans":[{"start":{"line":207,"offset":21},"end":{"line":215,"offset":18}}],"nameSpan":{"start":{"line":207,"offset":21},"end":{"line":207,"offset":28}},"childItems":[{"text":"deparam","kind":"function","kindModifiers":"","spans":[{"start":{"line":207,"offset":49},"end":{"line":215,"offset":18}}],"nameSpan":{"start":{"line":207,"offset":58},"end":{"line":207,"offset":65}},"childItems":[{"text":"coerced","kind":"var","kindModifiers":"","spans":[{"start":{"line":212,"offset":25},"end":{"line":212,"offset":161}}],"nameSpan":{"start":{"line":212,"offset":25},"end":{"line":212,"offset":32}}},{"text":"nonCoerced","kind":"var","kindModifiers":"","spans":[{"start":{"line":213,"offset":25},"end":{"line":213,"offset":165}}],"nameSpan":{"start":{"line":213,"offset":25},"end":{"line":213,"offset":35}}}]},{"text":"deparam","kind":"function","kindModifiers":"","spans":[{"start":{"line":207,"offset":31},"end":{"line":215,"offset":18}}],"nameSpan":{"start":{"line":207,"offset":39},"end":{"line":207,"offset":46}},"childItems":[{"text":"deparam","kind":"function","kindModifiers":"","spans":[{"start":{"line":207,"offset":49},"end":{"line":215,"offset":18}}],"nameSpan":{"start":{"line":207,"offset":58},"end":{"line":207,"offset":65}},"childItems":[{"text":"coerced","kind":"var","kindModifiers":"","spans":[{"start":{"line":212,"offset":25},"end":{"line":212,"offset":161}}],"nameSpan":{"start":{"line":212,"offset":25},"end":{"line":212,"offset":32}}},{"text":"nonCoerced","kind":"var","kindModifiers":"","spans":[{"start":{"line":213,"offset":25},"end":{"line":213,"offset":165}}],"nameSpan":{"start":{"line":213,"offset":25},"end":{"line":213,"offset":35}}}]}]}]},{"text":"isMatch","kind":"const","kindModifiers":"","spans":[{"start":{"line":143,"offset":17},"end":{"line":143,"offset":42}}],"nameSpan":{"start":{"line":143,"offset":25},"end":{"line":143,"offset":32}}},{"text":"isMatch","kind":"function","kindModifiers":"","spans":[{"start":{"line":395,"offset":17},"end":{"line":441,"offset":18}}],"nameSpan":{"start":{"line":395,"offset":26},"end":{"line":395,"offset":33}},"childItems":[{"text":"_ref3$strict","kind":"var","kindModifiers":"","spans":[{"start":{"line":403,"offset":25},"end":{"line":403,"offset":52}}],"nameSpan":{"start":{"line":403,"offset":25},"end":{"line":403,"offset":37}}},{"text":"_URI$parse2","kind":"var","kindModifiers":"","spans":[{"start":{"line":413,"offset":29},"end":{"line":413,"offset":82}}],"nameSpan":{"start":{"line":413,"offset":29},"end":{"line":413,"offset":40}}},{"text":"exact","kind":"var","kindModifiers":"","spans":[{"start":{"line":405,"offset":25},"end":{"line":405,"offset":44}}],"nameSpan":{"start":{"line":405,"offset":25},"end":{"line":405,"offset":30}}},{"text":"from","kind":"var","kindModifiers":"","spans":[{"start":{"line":396,"offset":25},"end":{"line":396,"offset":46}}],"nameSpan":{"start":{"line":396,"offset":25},"end":{"line":396,"offset":29}}},{"text":"matchAllExactly","kind":"var","kindModifiers":"","spans":[{"start":{"line":402,"offset":25},"end":{"line":402,"offset":64}}],"nameSpan":{"start":{"line":402,"offset":25},"end":{"line":402,"offset":40}}},{"text":"matchIgnorePath","kind":"var","kindModifiers":"","spans":[{"start":{"line":401,"offset":25},"end":{"line":401,"offset":64}}],"nameSpan":{"start":{"line":401,"offset":25},"end":{"line":401,"offset":40}}},{"text":"matchIgnoreQuery","kind":"var","kindModifiers":"","spans":[{"start":{"line":399,"offset":25},"end":{"line":399,"offset":66}}],"nameSpan":{"start":{"line":399,"offset":25},"end":{"line":399,"offset":41}}},{"text":"matchPathExactly","kind":"var","kindModifiers":"","spans":[{"start":{"line":400,"offset":25},"end":{"line":400,"offset":66}}],"nameSpan":{"start":{"line":400,"offset":25},"end":{"line":400,"offset":41}}},{"text":"matchQueryExactly","kind":"var","kindModifiers":"","spans":[{"start":{"line":398,"offset":25},"end":{"line":398,"offset":68}}],"nameSpan":{"start":{"line":398,"offset":25},"end":{"line":398,"offset":42}}},{"text":"path","kind":"var","kindModifiers":"","spans":[{"start":{"line":414,"offset":29},"end":{"line":414,"offset":52}}],"nameSpan":{"start":{"line":414,"offset":29},"end":{"line":414,"offset":33}}},{"text":"pathIsMatch","kind":"var","kindModifiers":"","spans":[{"start":{"line":421,"offset":25},"end":{"line":421,"offset":44}}],"nameSpan":{"start":{"line":421,"offset":25},"end":{"line":421,"offset":36}}},{"text":"query","kind":"var","kindModifiers":"","spans":[{"start":{"line":415,"offset":29},"end":{"line":415,"offset":54}}],"nameSpan":{"start":{"line":415,"offset":29},"end":{"line":415,"offset":34}}},{"text":"queryIsMatch","kind":"var","kindModifiers":"","spans":[{"start":{"line":420,"offset":25},"end":{"line":420,"offset":45}}],"nameSpan":{"start":{"line":420,"offset":25},"end":{"line":420,"offset":37}}},{"text":"strict","kind":"var","kindModifiers":"","spans":[{"start":{"line":404,"offset":25},"end":{"line":404,"offset":83}}],"nameSpan":{"start":{"line":404,"offset":25},"end":{"line":404,"offset":31}}},{"text":"target","kind":"var","kindModifiers":"","spans":[{"start":{"line":436,"offset":29},"end":{"line":436,"offset":164}}],"nameSpan":{"start":{"line":436,"offset":29},"end":{"line":436,"offset":35}}},{"text":"targetDescriptor","kind":"var","kindModifiers":"","spans":[{"start":{"line":397,"offset":25},"end":{"line":397,"offset":52}}],"nameSpan":{"start":{"line":397,"offset":25},"end":{"line":397,"offset":41}}},{"text":"targetLocation","kind":..

@sandersn
Copy link
Member

Does this assert (and the previous assert) occur with a call to tsc? I guess that it should but I could be wrong.

@sandersn
Copy link
Member

Also, the assert happens when merging module augmentations, which means that the program has (or the compiler thinks it has) syntax like declare module "foo" { ... } or declare global { ... }. This seems unlikely for a JS file -- maybe you have some typescript?

@mjbvz
Copy link
Contributor Author

mjbvz commented Jun 18, 2018 •
edited
Loading

Upgraded to 3.0@201806016. Seems to have Fixed the assertion failures and errors but I still see this file causing problems

@sandersn
Copy link
Member

What kind of problems?

@mjbvz
Copy link
Contributor Author

mjbvz commented Jun 19, 2018

Mainly that requests take a long to process, especially after any file edits

@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 19, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 19, 2018
@sandersn sandersn changed the title TSServer struggling with webpacked file TSServer slow when editing a webpacked file Jun 19, 2018
@sandersn
Copy link
Member

Do you mind sending the server logs exhibiting the slowness? When I compile, I see compile times around 2 1/2 seconds, and responsiveness in emacs is not great but feels like it's less than a second to produce quick info, parameter help, etc.

@mjbvz
Copy link
Contributor Author

mjbvz commented Jun 19, 2018

Log from VS Code with 3.0.0-201806016
tsserver.log.zip

I believe the problem is the absurdly large navtree response

@mhegazy mhegazy assigned ghost Jun 19, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jun 19, 2018

@Andy-MS can you take a look at the navtree issue..

@ghost ghost mentioned this issue Jun 19, 2018
Merged
@ghost ghost added the Fixed A PR has been merged for this issue label Jun 20, 2018
@mhegazy mhegazy closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandersn sandersn

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 3.0
Development

No branches or pull requests
4 participants
@sandersn @mhegazy @sheetalkamat @mjbvz