Skip to content

Missing optional argument in console.profileEnd #24869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krzysztof-grzybek opened this issue Jun 11, 2018 · 0 comments
Closed

Missing optional argument in console.profileEnd #24869

krzysztof-grzybek opened this issue Jun 11, 2018 · 0 comments
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 3.1

Comments

@krzysztof-grzybek
Copy link

krzysztof-grzybek commented Jun 11, 2018 •
edited
Loading

TypeScript Version: 3.0.0-dev.20180609

Search Terms: profileEnd console missing argument profile reportName

Code

console.profileEnd('myReportName')

https://github.com/Microsoft/TypeScript/blob/ba4bf21eade396ac0d82ab1278dfddc6ce69c653/lib/lib.webworker.d.ts#L323

Expected behavior: Type checker shouldn't complain about argument, according to MDN

Actual behavior: Type checker complains about argument. There is missing optional argument for console.profileEnd definition.

Playground Link:

Related Issues:

@krzysztof-grzybek krzysztof-grzybek mentioned this issue Jun 11, 2018
Merged
@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Jun 11, 2018
@mhegazy mhegazy added this to the Community milestone Jun 11, 2018
@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 11, 2018
@mhegazy mhegazy self-assigned this Jun 11, 2018
@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jun 11, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 3.0 Jun 11, 2018
@mhegazy mhegazy reopened this Jun 11, 2018
@mhegazy mhegazy modified the milestones: TypeScript 3.0, TypeScript 3.1 Jul 3, 2018
@mhegazy mhegazy mentioned this issue Jul 25, 2018
Merged
@mhegazy mhegazy added Fixed A PR has been merged for this issue and removed Fixed A PR has been merged for this issue labels Jul 25, 2018
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 3.1
Development

No branches or pull requests
2 participants
@krzysztof-grzybek @mhegazy