Skip to content

HTMLLinkElement.disabled deprecated ? #24119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Aqours opened this issue May 15, 2018 · 2 comments · Fixed by microsoft/TypeScript-DOM-lib-generator#488
Closed

HTMLLinkElement.disabled deprecated ? #24119

Aqours opened this issue May 15, 2018 · 2 comments · Fixed by microsoft/TypeScript-DOM-lib-generator#488
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 3.1

Comments

@Aqours
Copy link

Aqours commented May 15, 2018 •
edited
Loading

TypeScript Version: 2.8.3

Search Terms: htmllink, disabled, deprecated

Code
https://github.com/Microsoft/TypeScript/blob/ba4bf21eade396ac0d82ab1278dfddc6ce69c653/lib/lib.dom.d.ts#L6501-L6509

Expected behavior:
According to MDN HTMLLinkElement, HTMLLinkElement.disabled is not deprecated.

Actual behavior:
HTMLLinkElement.disabled has been deprecated by JSDoc in lib.dom.d.ts.

Playground Link:

Related Issues:

@mhegazy
Copy link
Contributor

mhegazy commented May 15, 2018

The file is auto-generated from the webidl definition of edge. they have marked it as deprecated, and that is why it shows up as such. we are moving to use the standard webidl where deprecated APIs will just not be added. so this should be fixed in the next release.

See #23653 for a related issue.

Meanwhile, PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels May 15, 2018
@mhegazy mhegazy added this to the Community milestone May 15, 2018
@irrationalRock irrationalRock mentioned this issue Jun 8, 2018
Merged
@mhegazy mhegazy modified the milestones: Community, TypeScript 3.0 Jun 8, 2018
@mhegazy mhegazy self-assigned this Jun 8, 2018
@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jun 8, 2018
@mhegazy mhegazy reopened this Jun 8, 2018
@EliSnow
Copy link

EliSnow commented Jun 11, 2018 •
edited
Loading

@mhegazy, does your response also apply to the Performance.timing api being marked as deprecated? Or is that a separate issue?

As far as I have been able to tell, it should not be deprecated.
Edit: nevermind, it is rightfully marked as deprecated as I discovered in the Navigation Timing Level 2 standard. MDN's docs are not updated.

@mhegazy mhegazy modified the milestones: TypeScript 3.0, TypeScript 3.1 Jul 3, 2018
@mhegazy mhegazy mentioned this issue Jul 25, 2018
Merged
@mhegazy mhegazy added Fixed A PR has been merged for this issue and removed Fixed A PR has been merged for this issue labels Jul 25, 2018
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 3.1
Development

Successfully merging a pull request may close this issue.

Fixed #24119 - Removed @deprecated for disabled in HTMLLinkElement irrationalRock/TSJS-lib-generator
3 participants
@EliSnow @mhegazy @Aqours