Skip to content

Formatting of conditional types #21716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
falsandtru opened this issue Feb 7, 2018 · 3 comments
Closed

Formatting of conditional types #21716

falsandtru opened this issue Feb 7, 2018 · 3 comments
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone
TypeScript 2.8

Comments

@falsandtru
Copy link
Contributor

TypeScript Version: 2.7.0-dev.20180206

Expected behavior:

type Diff<T, U> = T extends U ? never : T;

Actual behavior:

type Diff<T, U> = T extends U?never: T;

Related Issues:
@falsandtru falsandtru changed the title Formatting with conditional types Formatting of conditional types Feb 7, 2018
@mhegazy mhegazy added Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Feb 7, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Feb 7, 2018

@lankaapura wanna pick up this one as well?

@lankaapura
Copy link
Contributor

@mhegazy sure 👍

@lankaapura lankaapura mentioned this issue Feb 8, 2018
Merged
@lankaapura
Copy link
Contributor

lankaapura commented Feb 8, 2018 •
edited
Loading

Created PR #21762, let me know if there are any changes required.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Feb 8, 2018
@ghost ghost mentioned this issue May 22, 2018
Closed
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.8
Development

No branches or pull requests
3 participants
@lankaapura @falsandtru @mhegazy