-
Notifications
You must be signed in to change notification settings - Fork 13k
Closed
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: Quick FixesEditor-provided fixes, often called code actions.Editor-provided fixes, often called code actions.Help WantedYou can do thisYou can do thisVS Code TrackedThere is a VS Code equivalent to this issueThere is a VS Code equivalent to this issue
Milestone
Description
Problem
The install quick fix currently does a normal npm install. For cases where the version of npm used to manage a project is different than the version of npm found in the environment—npm 4 and npm 5 for example—this quick fix can also unexpectedly update the npm-shrinkwrap.json
.
Possible solution would be to run the @types
install with --no-shrinkwrap
Moving this issue over in case any one else want to weigh in here. We run into this in the VS Code codebase itself because we don't yet support npm 5
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: Quick FixesEditor-provided fixes, often called code actions.Editor-provided fixes, often called code actions.Help WantedYou can do thisYou can do thisVS Code TrackedThere is a VS Code equivalent to this issueThere is a VS Code equivalent to this issue