Skip to content

Apparent off-by-one error for extract method rename #18349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Sep 8, 2017 · 2 comments · Fixed by #18447
Closed

Apparent off-by-one error for extract method rename #18349

ghost opened this issue Sep 8, 2017 · 2 comments · Fixed by #18447
Labels
Bug A bug in TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue
Milestone
TypeScript 2.5.3

Comments

@ghost
Copy link

ghost commented Sep 8, 2017

See extract-method14.ts.
Ref: #18050 (comment)
@ghost ghost mentioned this issue Sep 8, 2017
Merged
@ghost ghost added Bug A bug in TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol labels Sep 8, 2017
@mhegazy mhegazy assigned ghost Sep 11, 2017
@mhegazy mhegazy added this to the TypeScript 2.5.3 milestone Sep 11, 2017
@ghost ghost mentioned this issue Sep 13, 2017
Merged
@ghost ghost closed this as completed in #18447 Sep 14, 2017
@ghost ghost added the Fixed A PR has been merged for this issue label Sep 14, 2017
@ghost
Copy link
Author

ghost commented Sep 14, 2017

@mhegazy Since this was just a problem with our tests I don't think it needs a release-2.5 port.

@mhegazy
Copy link
Contributor

mhegazy commented Sep 14, 2017

it should be fine to not port it.

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.5.3
Development

Successfully merging a pull request may close this issue.

Don't normalize whitespace in fourslash tests microsoft/TypeScript
1 participant
@mhegazy