Skip to content

lib.dom.ts incorrect return type for Document.elementFromPoint #14139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sccolbert opened this issue Feb 17, 2017 · 5 comments
Closed

lib.dom.ts incorrect return type for Document.elementFromPoint #14139

sccolbert opened this issue Feb 17, 2017 · 5 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone
Backlog

Comments

@sccolbert
Copy link

According to:
https://drafts.csswg.org/cssom-view/#dom-document-elementfrompoint

Document.elementFromPoint should return Element | null. It currently returns Element.
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 24, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Apr 24, 2017

Seems fixed in latest.

@mhegazy mhegazy closed this as completed Apr 24, 2017
@mhegazy mhegazy added this to the TypeScript 2.3.1 milestone Apr 24, 2017
@sccolbert
Copy link
Author

Not fixed in master:
https://github.com/Microsoft/TypeScript/blob/master/lib/lib.dom.d.ts#L3356

@mhegazy mhegazy added Help Wanted You can do this Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript and removed Fixed A PR has been merged for this issue labels May 6, 2017
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.3.1 May 6, 2017
@mhegazy mhegazy reopened this May 6, 2017
@mhegazy
Copy link
Contributor

mhegazy commented May 6, 2017

Sorry about that.

@saschanaz
Copy link
Contributor

Has been fixed now.

@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
@jakebailey
Copy link
Member

Just looking at old issues; yeah, this was fixed in #25944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@sccolbert @saschanaz @jakebailey @RyanCavanaugh @mhegazy