Skip to content

Match tags case-insensitively for uncommitted PRs #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

Match tags case-insensitively for uncommitted PRs #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/checks/addCommentToUncommittedPRs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe(addCommentToUncommittedPRs, () => {
expect(mockAPI.issues.createComment).not.toHaveBeenCalled()
})

for (const allowed of ["Experience Enhancement", "Committed", "help wanted"]) {
for (const allowed of ["Experience Enhancement", "Committed", "Help Wanted", "help wanted"]) {
it("Does not add a comment to an uncommented PR linked to a suggestion with the label " + allowed, async () => {
const { mockAPI, api } = createMockGitHubClient()

Expand Down
4 changes: 2 additions & 2 deletions src/checks/addCommentToUncommittedPRs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ export const addCommentToUncommittedPRs = async (api: Octokit, payload: PullRequ
else {
const isSuggestion = info.relatedIssues.some(issue => issue.labels?.find(l => {
const name = typeof l === "string" ? l : l.name;
return name === "Suggestion"
return name?.toLowerCase() === "suggestion"
}))
const isCommitted = info.relatedIssues.some(issue => issue.labels?.find(l => {
const name = typeof l === "string" ? l : l.name;
return name === "Committed" || name === "Experience Enhancement" || name === "help wanted"
return name?.toLowerCase() === "committed" || name?.toLowerCase() === "experience enhancement" || name?.toLowerCase() === "help wanted"
}))

if (isSuggestion && !isCommitted) {
Expand Down
Loading