Skip to content

Adds highlighting for the 'accessor' keyword #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2022
Merged

Adds highlighting for the 'accessor' keyword #917

merged 2 commits into from
Nov 11, 2022

Conversation

rbuckton
Copy link

DanielRosenwasser
DanielRosenwasser approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, but I was expecting it to be more like static

@DanielRosenwasser
Copy link
Member

Why is CI failing?

@sheetalkamat
Copy link
Member

checking

@sheetalkamat sheetalkamat merged commit 359e091 into master Nov 11, 2022
@sheetalkamat sheetalkamat deleted the auto-accessor branch November 11, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuckton @DanielRosenwasser @sheetalkamat