Add WebRTC Stats spec #919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes bringing in the WebRTC Stats spec. The driver here is updating the
RTCStatsType
enum values, as described in microsoft/TypeScript#36650, but there are other changes that the README-recommendedfetch-idl
process brings in as well.My initial thinking was that getting all the spec updates in is preferable, but I'm also not totally sure where browser adoption is for this spec, so I'm not sure what level belongs in TypeScript. Could isolate to just
RTCStatsType
to mitigate risk.Side note: importing this spec via the README instructions did require a bit of editing to remove the text "WebIDL" in front of each WebIDL block, due to a
.idlHeader
element with that text appearing inside the.idl
code block. It looks like a number of other specs have a similar thing going on:Gamepad
Push
Screen Orientation
Selection
Web Share
WebRTC Stats
I'm happy to open a separate issue to suggest some kind of filtering to avoid similar manual IDL-editing effort in the future if that makes sense - just let me know.