Emit iterable arguments for ES2015+ #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Jun 4, 2019
src/emitter.ts
Outdated
| return !!s.param && s.param.some(p => typeIncludesSequence(p.type)); | ||
| } | ||
|
|
||
| function filterSignaturesWithSequence(signature: Browser.Signature[]): Browser.Signature[] { |
There was a problem hiding this comment.
nit: can you name the function replaceSignaturesWithSequence and the parameter signatures?
src/emitter.ts
Outdated
| function filterSignaturesWithSequence(signature: Browser.Signature[]): Browser.Signature[] { | ||
| return signature.filter(hasSequenceArgument).map(s => { | ||
| const newParams = s.param!.map(p => { | ||
| const typedef = typeof p.type === "string" ? sequenceTypedefMap[p.type]: undefined; |
There was a problem hiding this comment.
you could drop lines 1227-1229 if you use p.type instead of undefined. It's less efficient but that's not a concern here.
Suggested change
| const typedef = typeof p.type === "string" ? sequenceTypedefMap[p.type]: undefined; | |
| const typedef = typeof p.type === "string" ? sequenceTypedefMap[p.type] : p.type; |
There was a problem hiding this comment.
Doing that will break code as sequenceTypedefMap[p.type] also can be undefined.
sandersn
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/TypeScript#28198.