Override Node nextSibling to be type of ChildNode. #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @weswigham who added the related issue to https://github.com/Microsoft/TypeScript/milestone/2 some days ago! I'd be happy if someone could give a feedback! :) |
sandersn
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Seems like a reasonable improvement even if it's not completely as accurate as @saschanaz' suggestion.
|
The type of previousSibling should be modified accordingly ... |
|
I agree, ran into this recently as well. Open a new issue...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in microsoft/TypeScript#28551 a Node's
nextSiblingshould have type ofChildNodeso types can match when comparing or assigning elements.I've noticed also
nextSiblingpresent in the interfaceMutationRecordhere and in the interfaceTreeWalkeras a method here.Not sure about those other two occurrences, but at least it seems consistent the change in
Node. Let me know if you guys have any comment!Cheers!