Add focusin, focusout events to DocumentEventMap/HTMLElementEventMap

[lankaapura]

Fixes microsoft/TypeScript#21822

[mhegazy]

these files are autogrenerated and we do not manually change them.So we will need to add support for adding even handler maps to the generation script and add them to overridingTypes.json instead.

[lankaapura]

@mhegazy thanks, I'll update the PR.

[lankaapura]

Hi @mhegazy

I have added following to addedTypes.json but it doesn't generate anything. Do I have to update somewhere else too? I suspect that it's the double quotes in DocumentEventMap properties. (ex: "blur": FocusEvent; ) but not sure.

{
        "kind": "property",
        "interface": "DocumentEventMap",
        "name": "\"focusin\"",
        "type": "FocusEvent"
    },
    {
        "kind": "property",
        "interface": "DocumentEventMap",
        "name": "\"focusout\"",
        "type": "FocusEvent"
    }

[saschanaz]

Type additions for *EventMap interfaces are currently ignored, this is why the test passes without any baseline updates.

[lankaapura]

Thanks @saschanaz so do I need to update TS.fsx file to include it? or any other suggestions to fix the issue?

[saschanaz]

TS.fsx update is needed.

…

Sent from my Windows 10 phone From: Priyantha Lankapura<mailto:[email protected]> Sent: Wednesday, February 14, 2018 2:51 PM To: Microsoft/TSJS-lib-generator<mailto:[email protected]> Cc: Kagami Sascha Rosylight<mailto:[email protected]>; Mention<mailto:[email protected]> Subject: Re: [Microsoft/TSJS-lib-generator] Add focusin, focusout events to DocumentEventMap/HTMLElementEventMap (#369) Thanks @saschanaz<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsaschanaz&data=02%7C01%7C%7Ca0e97bff5e3b4355fabb08d5736ef582%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636541842752502616&sdata=6qA1GwKAV4AWMTREma1haIuLqxcHbM39wi8x%2BXH5SFQ%3D&reserved=0> so do I need to update TS.fsx file to include it? or any other suggestions to fix the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FTSJS-lib-generator%2Fpull%2F369%23issuecomment-365503601&data=02%7C01%7C%7Ca0e97bff5e3b4355fabb08d5736ef582%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636541842752502616&sdata=aHtGAtEP7qIagf6Zi3jkaQdr2jKhNVDwKnfJZdaugV4%3D&reserved=0>, or mute the thread<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADPUTkBX7T799fUO4FLvZGQ43ynjANHQks5tUnRRgaJpZM4SA1UN&data=02%7C01%7C%7Ca0e97bff5e3b4355fabb08d5736ef582%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636541842752502616&sdata=15%2Bf3DLiMm13aEXgWPu%2FMr8IYUHcGQs3HJvqjkyDBNU%3D&reserved=0>.

[lankaapura]

@saschanaz @mhegazy PR updated. Pls review.

[dumistoklus]

Why this PR not in master branch still?

[chicoxyzzy]

FocusEvents are still not there https://github.com/Microsoft/TSJS-lib-generator/blob/master/src/emitter.ts#L27-L38

[stevenyxu]

I also want focusin/focusout because it's inconvenient to keep on writing addEventListener('focusin' as any as keyof HTMLElementEventMap, ...).

But HTMLElementEventMap is generated from https://github.com/Microsoft/TSJS-lib-generator which requires that the event be in a W3C candidate recommendation or further, but I could only find focusin in a working draft https://www.w3.org/TR/uievents/#event-type-focusin. I don't know that it will make it based on the current standard for inclusion.

[anyexinglu]

So guys, which version has the 'focusin' and 'focusout'?

[saschanaz]

#696 added them again, so I think the next release will have it.