-
Notifications
You must be signed in to change notification settings - Fork 448
Handle Properties in kdl #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Handle Properties in kdl #2088
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f7c15b7
Enhance mixin handling in KDL parser by adding functions to extract e…
Bashamega 4c5d916
chore: migrate
Bashamega 7570cf8
extra line
Bashamega 0156114
-
Bashamega 23965c3
split it
Bashamega a263457
Rename files
Bashamega e707e51
-
Bashamega de05586
Update src/build/patches.ts
Bashamega 9dce3c9
Update src/build/patches.ts
Bashamega 8cfd4dc
Merge branch 'microsoft:main' into kdl/property
Bashamega 812b211
Update patches.ts
Bashamega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
interface-mixin WebGLRenderingContextBase { | ||
property canvas exposed=Window | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to return a value as handleProperty now does. But as handleEnum already does this, this can be done in a separate PR.