chore: correct MDN link for requestAnimationFrame and cancelAnimation… #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Frame The previous MDN reference for requestAnimationFrame was outdated/incorrect. This commit updates it to the current valid MDN URL: https://developer.mozilla.org/docs/Web/API/window/requestAnimationFrame
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
@microsoft-github-policy-service agree |
Bashamega
suggested changes
Jun 16, 2025
|
This is tricky, to fix this we need a way to make the comments per-global, otherwise the link becomes incorrect for workers. For now I filed mdn/content#39951 to mitigate this a bit. |
|
@saschanaz So do I still need to handle this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Frame
The previous MDN reference for requestAnimationFrame was outdated/incorrect. This commit updates it to the current valid MDN URL: https://developer.mozilla.org/docs/Web/API/window/requestAnimationFrame