Invoke-UpdateCheck fixes #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a regression that was introduced in microsoft#242. A `Write-Log` command was accidentally updated to pass in `=Message` instead of `-Message`. * Updates the web request to suppress the progress bar using $ProgressPreference = 'SilentlyContinue' Fixes microsoft#249 Fixes microsoft#250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced by #242 unfortunately when I was reducing the lines in the module that exceeded 100 chars.
Specifically:
PowerShellForGitHub/UpdateCheck.ps1
Line 86 in 17f6122
(note the
=Messageinstead of the-Message)Updates the web request to suppress the progress bar using
$ProgressPreference = 'SilentlyContinue'Adds a
-Forceswitch to force the update check to happen again to make future debugging scenarios easier.Issues Fixed
Fixes #249
Fixes #250
References
n/a
Checklist
Changes to the manifest file follow the manifest guidance.Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.Relevant usage examples have been added/updated in USAGE.md.If desired, ensure your name is added to our Contributors list