-
Notifications
You must be signed in to change notification settings - Fork 279
Use proxy references to resolve references #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaggieKimani1
merged 59 commits into
release/2.0.0
from
mk/use-proxy-reference-for-ref-resolution
Apr 3, 2024
Merged
Use proxy references to resolve references #1603
MaggieKimani1
merged 59 commits into
release/2.0.0
from
mk/use-proxy-reference-for-ref-resolution
Apr 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the proxy reference object
…ce classes to the deserializers
…to mk/use-proxy-reference-for-ref-resolution
…s for ref resolution
… and pass it to the proxy's constructor
…reference constructor
…ost document in the proxy Reference's property
…ion; remove unnecessary null check
… reference classes to override
darrelmiller
reviewed
Apr 3, 2024
darrelmiller
reviewed
Apr 3, 2024
darrelmiller
reviewed
Apr 3, 2024
darrelmiller
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
host OpenApi documentinstance passed in their constructor in order to find the target the $refs point to and dereferences them lazily.OpenApiReferenceResolvervisitor to locate and resolve references. With this approach, the second pass includes walking through the document instance and using aHostDocumentResolvervisitor that visits all proxy reference objects and sets the value of the host document.To note:
Fixes #1571