fix: invariant culture for version field #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing version field depends on current system culture version: '1.13.0' for `en-US` version: 1.13.0 for `en-GB` existing workaround: set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT environment variable https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode
Ne4to
requested review from
MaggieKimani1,
baywet,
darrelmiller,
irvinesunday,
millicentachieng,
peombwa and
zengin
as code owners
Contributor
Author
|
It looks like one of the checks is not able to report status. How can I force to restart the check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing version field depends on current system culture
version: '1.13.0'foren-USversion: 1.13.0foren-GBexisting workaround:
set
DOTNET_SYSTEM_GLOBALIZATION_INVARIANTenvironment variablehttps://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode