This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Use Common Form tooling #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows my work converting the current Markdown text to Common Form-compatible markup, as well as the structural fixes I was able to make thanks to Common Form tooling. I've also attached sample renderings in various formats.
A couple nits spotted:
"Output" is defined in the singular, covers all output, but used twice in the plural.
Subject-verb number agreement error in the general warranty disclaimer.
Personally, I'd also pick either singular "Upstream Data Provider" singular or "Upstream Data Providers" plural and use throughout.
Time permitting, I do plan to make substantive comments. But I start with getting this kind of text over into workable formats if I can, and thought I might as well share.
For what it's worth, I do expect using this more idiomatic approach to typing up in Markdown could get you more PRs. That's been my experience with other legal terms on GitHub.