cleaner variables incl variable template #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 19, 2019 13:29
Simplified and cleaned-up the usage of variables inside all python files and Azure DevOps pipelines. Variables are now defined in two places, the Azure DevOps variable template and the Azure DevOps variable group. - Refactored dotenv usage in a singleton class to serve variables to all python scripts - Created new variable template `azdo-variables.yml` to be used within Azure DevOps pipelines - Adjusted existing pipelines to leverage new variable template - Prepared the ARM template to specify individual names for the various resources Please provide feedback, I'll update the PR with documentation modifications Resolves: #279075
The workspace has now to be defined in the variable group - Adjusted infrastructure as code template
In case there is no WORKSPACE_NAME in the Azure DevOps variable group we build up the workspace using the provided BASE_NAME variable.
Describes the usage of all variable definitions
Contributor
Author
|
Are forked PRs are able to run the pipeline due to SP_APP_SECRET? |
dtzar
suggested changes
Nov 19, 2019
Contributor
dtzar
left a comment
dtzar
left a comment
There was a problem hiding this comment.
Please also do the following:
- Cleanup .env.example, removing unused ENV vars
- Cleanup / verify getting started example
We should have people only put what is required into the task group & .env.example
dtzar
reviewed
Nov 19, 2019
dtzar
reviewed
Nov 19, 2019
dtzar
reviewed
Nov 19, 2019
added 2 commits
November 20, 2019 10:20
- Removed unnecessary variables from `azdo-variables.yml` - `workspace` is now a required ARM template parameter. Needs to be existant in the variable group as `WORKSPACE_NAME` - Cleand-up `.env.example` to only include variables needed to execute scripts in local environments
Included pointers where to find the proper variable options in order to execute the project locally vs. Azure DevOps
dtzar
approved these changes
Nov 20, 2019
dtzar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified and cleaned-up the usage of variables inside all python files
and Azure DevOps pipelines. Variables are now defined in two places, the
Azure DevOps variable template and the Azure DevOps variable group.
python scripts
azdo-variables.ymlto be used withinAzure DevOps pipelines
resources
The workspace has now to be defined in the variable group
In case there is no WORKSPACE_NAME in the Azure DevOps variable group we
build up the workspace using the provided BASE_NAME variable.
Describes the usage of all variable definitions
azdo-variables.ymlworkspaceis now a required ARM template parameter. Needs to exist in the variable group asWORKSPACE_NAME.env.exampleto only include variables needed to executescripts in local environments
Included pointers where to find the proper variable options in order to
execute the project locally vs. Azure DevOps