Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/MICore/CommandFactories/MICommandFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -669,12 +669,6 @@ public virtual bool CanDetach()
/// <returns>[Required] Task to track when this is complete</returns>
abstract public Task EnableTargetAsyncOption();

/// <summary>
/// Obtains a Results object containing the set of features supported by the debugger.
/// </summary>
/// <returns>[Required] Task that will contain the Results.</returns>
abstract public Task<Results> ListTargetFeatures();

public virtual bool SupportsBreakpointChecksums()
{
return false;
Expand Down
5 changes: 0 additions & 5 deletions src/MICore/CommandFactories/clrdbg.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ public override Task<List<ulong>> StartAddressesForLine(string file, uint line)
return Task.FromResult<List<ulong>>(null);
}

public override Task<Results> ListTargetFeatures()
{
return Task.FromResult(new Results(ResultClass.None));
}

public override Task EnableTargetAsyncOption()
{
// clrdbg is always in target-async mode
Expand Down
6 changes: 0 additions & 6 deletions src/MICore/CommandFactories/gdb.cs
Original file line number Diff line number Diff line change
Expand Up @@ -183,12 +183,6 @@ public override async Task<List<ulong>> StartAddressesForLine(string file, uint
return addresses;
}

public override async Task<Results> ListTargetFeatures()
{
Results results = await _debugger.CmdAsync("-list-target-features", ResultClass.done);
return results;
}

public override Task EnableTargetAsyncOption()
{
// Linux attach TODO: GDB will fail this command when attaching. This is worked around
Expand Down
5 changes: 0 additions & 5 deletions src/MICore/CommandFactories/lldb.cs
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,6 @@ public override Task<List<ulong>> StartAddressesForLine(string file, uint line)
return Task.FromResult<List<ulong>>(null);
}

public override Task<Results> ListTargetFeatures()
{
return Task.FromResult(new Results(ResultClass.None));
}

public override Task EnableTargetAsyncOption()
{
// lldb-mi doesn't support target-async mode, and doesn't seem to need to
Expand Down
6 changes: 1 addition & 5 deletions src/MIDebugEngine/Engine.Impl/DebuggedProcess.cs
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,7 @@ public async Task Initialize(HostWaitLoop waitLoop, CancellationToken token)

try
{
Results res = await this.MICommandFactory.ListTargetFeatures();
if (res.Contains("async"))
{
await this.MICommandFactory.EnableTargetAsyncOption();
}
await this.MICommandFactory.EnableTargetAsyncOption();
List<LaunchCommand> commands = GetInitializeCommands();
_childProcessHandler?.Enable();

Expand Down