Merge master into release_mdd #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support ClipboardContext for Evaluate Request Users who want to copy the full string from the UI will use "copy value" from the EE windows. This will send an EvaluateRequest with the context of Clipboard. This PR noticies the context in OpenDebugAD7 and uses IDebugExpressionDAP with DAPEvalFlag ClipboardContext set for MIEngine to query. If it is set, MIEngine will save the previous value of 'show print elements', set it to unlimited, and reset it back to the original value after it evaluates the variable. Then it will provide the full string back to the user to copy.
* Fixing Conditional Breakpoints for VS Code VS Code has modified the way it handles conditional breakpoints. It used to send a SetBreakpoints that removed the breakpoint and a new SetBreakpoints request with the updated condition. First we validate existing breakpoint's conditions have not changed, if they have, we delete and recreate it internally.
* Add support for LogPoints in OpenDebugAD7 This PR adds LogMessage (Tracepoint) support for OpenDebugAD7. The messages with curl braces will have the expression inside of them evaluated. There is also support to replace tokens such as $PNAME,$TNAME,$TID,$CALLSTACK,$CALLER will have their values replaced.
Made the ListProcesses() error message for the Docker 'Attach to Process' scenario more specific.
Before:
Failed to list processes.
'ps' command failed with exit code '126'.
Error:
''
Parsing '/proc' for process list failed.
Error:
''
After:
Failed to list processes.
'ps' command failed with exit code '126'.
Error:
''
Parsing '/proc' for process list failed.
Error:
''
Ensure the selected Docker Connection target is a Linux Container.
…nd Telemetry (#1017) In the Container Picker Dialog, it uses Name and ShortId. However, if Id is null, ShortId tries to get the length of the Id and this causes a NullRefException. We also are adding null containers for GetRemoteDockerContainers. Added a null check. Adding a null check on Id so it just returns null. Added support for logging errors to the output window. Added telemetry to count for errors in Docker process listings
… "Select Docker Container" window (#1021) Added Container OS/Platform information in the Docker container picker view. It will query `docker version` to get the Server's OS, however is LCOW is enabled and the user set the docker daemon to use Windows Containers. We will query using `docker inspect` to see if it acutally is running Windows or Linux on the containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.