Execution Tests: Long Vector - Fix off by 1 bug in WaveActiveAllEqual #7930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanp
approved these changes
Nov 18, 2025
Comment on lines
1374
to
1378
| std::vector<HLSLBool_t> Expected; | ||
| const size_t VectorSize = Inputs[0].size(); | ||
| Expected.assign(VectorSize - 1, static_cast<HLSLBool_t>(true)); | ||
| Expected.assign(VectorSize, static_cast<HLSLBool_t>(true)); | ||
| // We set the last element to a different value on a single lane. | ||
| Expected[VectorSize - 1] = static_cast<HLSLBool_t>(false); |
Member
There was a problem hiding this comment.
Code golf:
std::vector<HLSLBool_t> Expected(Inputs[0].size() - 1, static_cast<HLSLBool_t>(true));
Expected.push_back(static_cast<HLSLBool_t>(false));std::vector<HLSLBool_t> Expected(Inputs[0].size(), static_cast<HLSLBool_t>(true));
Expected.back() = static_cast<HLSLBool_t>(false);
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an off by 1 error when filling the expected output vector for WaveActiveAllEqual tests.