Moved HANDLE management to Test Class Constructor and Destructor #7357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
damyanp
reviewed
Apr 16, 2025
damyanp
approved these changes
Apr 17, 2025
alecardoso-tech
changed the title
damyanp
approved these changes
Apr 18, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Approved, assuming the answer to the comment below is that everything still works ok.
alsepkow
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test class
ShaderOpTesthad aHANDLEnot closed afterRunShaderOptest ran.Created a constructor and destructor for the Test Class to manage the
HANDLE.