Fix field names in long vector DICompositeType #7332
Merged
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoll
added a commit
to anupamachandra/DirectXShaderCompiler
that referenced
this pull request
Apr 10, 2025
damyanp
reviewed
Apr 10, 2025
jeffnn
approved these changes
Apr 10, 2025
llvm-beanz
reviewed
Apr 10, 2025
llvm-beanz
reviewed
Apr 10, 2025
tex3d
reviewed
Apr 11, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks mostly good with some good suggestions/comments from others.
llvm-beanz
approved these changes
Apr 11, 2025
tex3d
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix OOB accesses for debug info vector field names for vectors of length >4.