Basic implementation of priority long vector exec tests. #7320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
alsepkow
commented
Apr 7, 2025
damyanp
requested changes
Apr 8, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
My comments here are mainly observations. The main (pun unintended) change I'm requesting is that this to the is retargeted to the staging branch. I think there's quite a lot of work we'll want to do before this is ready to go to main.
alsepkow
force-pushed
the
user/alsepkow/LongVecExec_2
branch
from
5ae4e92 to
e7d2725
Compare
llvm-beanz
reviewed
Apr 11, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
alsepkow
commented
Apr 16, 2025
| <RootValues> | ||
| <RootValue Index="0" ResName="LongVectorOp" /> | ||
| </RootValues> | ||
| <Shader Name="CS" Target="cs_6_0"> |
Contributor
Author
There was a problem hiding this comment.
This is misleading because we override the values in the callback of RunShaderOp. I'll add a comment to the XML.
Contributor
Author
There was a problem hiding this comment.
I updated to use the target defined here instead of overriding.
…p may have a precision issue
alsepkow
force-pushed
the
user/alsepkow/LongVecExec_2
branch
from
a19df14 to
e148abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a basic implementation of the priority long vector execution tests #7260.