[SER] 'reordercoherent' HLSL attribute and DXIL encoding #7250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoll
force-pushed
the
ser_reordercoherent_patch
branch
from
c34e1e1 to
f7ac9b8
Compare
tex3d
reviewed
Mar 31, 2025
tex3d
reviewed
Apr 3, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looking good; some minor comments.
tools/clang/test/HLSLFileCheck/hlsl/types/modifiers/reordercoherent/reordercoherent2.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheck/hlsl/types/modifiers/reordercoherent/reordercoherent.hlsl
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheck/hlsl/types/modifiers/reordercoherent/reordercoherent3.hlsl
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheck/hlsl/types/modifiers/reordercoherent/reordercoherent_ast.hlsl
Show resolved
Hide resolved
...s/clang/test/HLSLFileCheck/hlsl/types/modifiers/reordercoherent/reordercoherent_for_arg.hlsl
Outdated
Show resolved
Hide resolved
...s/clang/test/HLSLFileCheck/hlsl/types/modifiers/reordercoherent/reordercoherent_for_arg.hlsl
Outdated
Show resolved
Hide resolved
simoll
force-pushed
the
ser_reordercoherent_patch
branch
2 times, most recently
from
4db620d to
d7d30ad
Compare
Collaborator
Author
|
There was a comment requesting a test for invalid dxil. Not adding that test here but tracking this under #7214 (as we do for the other 'check-fail' tests) |
tex3d
previously approved these changes
Apr 4, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks good.
Only one minor thing I noticed, where the dxcdisassembler.cpp should probably be updated to print the new attribute.
tools/clang/test/CodeGenDXIL/hlsl/attributes/reordercoherent_for_arg.hlsl
Outdated
Show resolved
Hide resolved
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md 'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453 DXC SER implementation tracker: microsoft#7214
simoll
force-pushed
the
ser_reordercoherent_patch
branch
from
d7d30ad to
d343b2d
Compare
Collaborator
Author
|
I've addressed all the remaining minor requests. This is ready to merge from my end. |
llvm-beanz
reviewed
Apr 6, 2025
Co-authored-by: Chris B <[email protected]>
Co-authored-by: Chris B <[email protected]>
Co-authored-by: Chris B <[email protected]>
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tex3d
previously approved these changes
Apr 7, 2025
llvm-beanz
reviewed
Apr 8, 2025
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
One small request with a suggestion to apply.
Co-authored-by: Chris B <[email protected]>
llvm-beanz
previously approved these changes
Apr 8, 2025
llvm-beanz
approved these changes
Apr 8, 2025
Collaborator
Author
|
@tex3d @llvm-beanz . please re-review. I've updated the test, this is ready to merge from my end |
simoll
added a commit
to simoll/DirectXShaderCompiler
that referenced
this pull request
May 5, 2025
Validates: All resources All instructions using resources Rules: 'reordercoherent' may only be used in SM6.9+ in resource handles and resource declarations. Increment/DecrementCounter unsupported on 'reordercoherent' resources. Create a new DXIL 1.9 variant of the 'CompileWhenOkThenCheckRDAT' container test and restore the old one without 'reordercoherent' (pre-microsoft#7250). The validator now rejects 'reordercoherent' in DXIL 1.3 and accepts from DXIL 1.9+. SER implementation tracker: microsoft#7214
damyanp
pushed a commit
that referenced
this pull request
May 9, 2025
Validates: All resources All instructions using resources Rules: 'reordercoherent' may only be used in SM6.9+ in resource handles and resource declarations. Increment/DecrementCounter unsupported on 'reordercoherent' resources. Create a new DXIL 1.9 variant of the 'CompileWhenOkThenCheckRDAT' container test and restore the old one without 'reordercoherent' (pre-#7250). The validator now rejects 'reordercoherent' in DXIL 1.3 and accepts from DXIL 1.9+. SER implementation tracker: #7214 --------- Co-authored-by: Tex Riddell <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453
DXC SER implementation tracker: #7214