Skip to content

Conversation

@ybroeker
Copy link
Contributor

@ybroeker ybroeker commented Apr 4, 2020

This PR adds tests for creation of types which are used as fields but not directly as return- or parameter-types of queries and mutations.

Copy link
Contributor

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ybroeker . @andymc12 can you also have a look ? Thanks

@phillip-kruger phillip-kruger requested a review from andymc12 April 6, 2020 07:18
@ybroeker ybroeker changed the title Add tests for creation if referenced types Add tests for creation of referenced types Apr 6, 2020
Copy link
Contributor

@andymc12 andymc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillip-kruger phillip-kruger merged commit ae0f27d into microprofile:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants