Add tests for @Source used with other inputs
#218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yannick Bröker <[email protected]>
phillip-kruger
approved these changes
Apr 6, 2020
Contributor
phillip-kruger
left a comment
phillip-kruger
left a comment
There was a problem hiding this comment.
LGTM ! Thanks @ybroeker
Contributor
|
@andymc12 - can you also have a look please ? |
andymc12
reviewed
Apr 7, 2020
Contributor
andymc12
left a comment
andymc12
left a comment
There was a problem hiding this comment.
I think this looks good. My only comment was that it might be nice to also have a test where the second parameter is annotated with @NonNull. Thanks!
server/tck/src/main/java/org/eclipse/microprofile/graphql/tck/apps/basic/api/SourceTestApi.java
Show resolved
Hide resolved
Contributor
|
@andymc12 please merge once you are happy. |
ybroeker
force-pushed
the
test-sourceWithInput
branch
from
1d734d9 to
87e7f85
Compare
Signed-off-by: Yannick Bröker <[email protected]>
ybroeker
force-pushed
the
test-sourceWithInput
branch
from
87e7f85 to
117fe6c
Compare
Signed-off-by: Yannick Bröker <[email protected]>
Signed-off-by: Yannick Bröker <[email protected]>
Contributor
|
@andymc12 - can we merge this one ? |
Contributor
|
@phillip-kruger yes, sorry for the delay - I'll merge now. Thanks @ybroeker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some test cases for input-arguments used in conjunction with
@Source.