Skip to content

img: add width and height #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: lib
Choose a base branch
from
Open

img: add width and height #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce653c
img: add width and height
aurelienpierre Mar 31, 2021
3bb3b64
check if file exists to prevent errors with tests
aurelienpierre Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Michelf/Markdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,13 @@ protected function _doImages_reference_callback($matches) {
if (isset($this->urls[$link_id])) {
$url = $this->encodeURLAttribute($this->urls[$link_id]);
$result = "<img src=\"$url\" alt=\"$alt_text\"";
if(file_exists($url))
{
list($width, $height, $type, $attr) = getimagesize($url);
if(isset($width)) $result .= " width=\"$width\"";
if(isset($height)) $result .= " height=\"$height\"";
if(isset($width) && isset($height)) $result .= " loading=\"lazy\"";
}
if (isset($this->titles[$link_id])) {
$title = $this->titles[$link_id];
$title = $this->encodeAttribute($title);
Expand Down Expand Up @@ -893,6 +900,13 @@ protected function _doImages_inline_callback($matches) {
$alt_text = $this->encodeAttribute($alt_text);
$url = $this->encodeURLAttribute($url);
$result = "<img src=\"$url\" alt=\"$alt_text\"";
if(file_exists($url))
{
list($width, $height, $type, $attr) = getimagesize($url);
if(isset($width)) $result .= " width=\"$width\"";
if(isset($height)) $result .= " height=\"$height\"";
if(isset($width) && isset($height)) $result .= " loading=\"lazy\"";
}
if (isset($title)) {
$title = $this->encodeAttribute($title);
$result .= " title=\"$title\""; // $title already quoted
Expand Down
14 changes: 14 additions & 0 deletions Michelf/MarkdownExtra.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,13 @@ protected function _doImages_reference_callback($matches) {
if (isset($this->urls[$link_id])) {
$url = $this->encodeURLAttribute($this->urls[$link_id]);
$result = "<img src=\"$url\" alt=\"$alt_text\"";
if(file_exists($url))
{
list($width, $height, $type, $attr) = getimagesize($url);
if(isset($width)) $result .= " width=\"$width\"";
if(isset($height)) $result .= " height=\"$height\"";
if(isset($width) && isset($height)) $result .= " loading=\"lazy\"";
}
if (isset($this->titles[$link_id])) {
$title = $this->titles[$link_id];
$title = $this->encodeAttribute($title);
Expand Down Expand Up @@ -1064,6 +1071,13 @@ protected function _doImages_inline_callback($matches) {
$alt_text = $this->encodeAttribute($alt_text);
$url = $this->encodeURLAttribute($url);
$result = "<img src=\"$url\" alt=\"$alt_text\"";
if(file_exists($url))
{
list($width, $height, $type, $attr) = getimagesize($url);
if(isset($width)) $result .= " width=\"$width\"";
if(isset($height)) $result .= " height=\"$height\"";
if(isset($width) && isset($height)) $result .= " loading=\"lazy\"";
}
if (isset($title) && $title_quote) {
$title = $this->encodeAttribute($title);
$result .= " title=\"$title\""; // $title already quoted
Expand Down