Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Improve PHPUnit fixture #10

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Improve PHPUnit fixture #10

merged 1 commit into from
Mar 18, 2021

Conversation

@peter279k
Copy link
Contributor

@peter279k peter279k commented Mar 11, 2021

Changed log

  • According to the official PHPUnit doc, it should be protected function setUp method.

@michaelsavchuk
Copy link
Owner

michaelsavchuk commented Mar 18, 2021

Good catch! Functionally it doesn't matter but adhering to official examples is good :)

Thanks!

@michaelsavchuk michaelsavchuk merged commit 6bd62c5 into michaelsavchuk:master Mar 18, 2021
@peter279k peter279k deleted the improve_phpunit_fixtures branch March 18, 2021 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peter279k @michaelsavchuk