Add binary UUID relationship support #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements BinaryUuidBuilder to enable Eloquent relationships when using EfficientUuid cast with BINARY(16) storage. Addresses issue michaeldyrynda#65. Features: - Custom query builder that converts UUID strings to binary automatically - Opt-in via UsesBinaryUuidBuilder trait - Full support for belongsTo, hasMany, hasOne relationships - Eager loading support (with, whereIn queries) - whereNotIn support for exclusion queries Testing: - 22 new comprehensive tests (78 total, 144 assertions) - 100% backward compatible - all existing tests pass - Edge cases covered (invalid UUIDs, empty arrays, qualified columns) - Complex query scenarios tested Implementation: - Zero performance penalty for non-UUID queries - Strict type checking (PHPStan ready) - No breaking changes to existing functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements BinaryUuidBuilder to enable Eloquent relationships when using EfficientUuid cast with BINARY(16) storage. Addresses issue #65.
Features:
Testing:
Implementation: