Skip to content

Conversation

@sshiraiwa
Copy link
Member

@sshiraiwa sshiraiwa commented Jun 2, 2025

@justinlaughlin

Please take a look at this PR and see how I am cleaning up the setup.py

I started from imporve-install. I did a couple of things

  1. added a custom backend, which seems necessary to handle -C "--build_options xxxx"
  2. made routines for building libraries (metis xxx) in the separate file.
  3. all routines needed for build is moved under _build_system
  4. added build_globals.py to store build parameters, which can be changed based on user input
  5. added build_consts.py to store constant parameters, which does not change once it set
  6. used all to use "from xxx import *", instead of listing up each items

Status:
following command build MFEM, generate wrapper, and build wrapper.

 pip install .  -C"--verbose --build-options=--mfem-branch='master'" --no-cache-dir --no-binary mfem --verbose

However, I am having numpy 2.0 related issue.

@sshiraiwa sshiraiwa requested a review from justinlaughlin June 2, 2025 13:50
sshiraiwa added 28 commits June 3, 2025 11:32
…ml. Other minor fix. Build seems okay in my local env.
@sshiraiwa sshiraiwa added this to the PyMFEM 4.8 milestone Jun 5, 2025
@sshiraiwa sshiraiwa mentioned this pull request May 31, 2025
17 tasks
@sshiraiwa sshiraiwa self-assigned this Jun 5, 2025
@sshiraiwa sshiraiwa added enhancement Python3.12 Issues relating to Python3.12 Python 3.13 Issues relating to Python 3.13 build mac labels Jun 5, 2025
@sshiraiwa
Copy link
Member Author

@justinlaughlin
I think that this PR is ready to merge.
Please merge it to improve-install and undo "draft".
After combining this to PR278, we could merge PR278.

@justinlaughlin justinlaughlin merged commit bebd44f into improve-install Jun 5, 2025
27 checks passed
@sshiraiwa sshiraiwa deleted the improve-install2 branch June 5, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build enhancement mac Python3.12 Issues relating to Python3.12 Python 3.13 Issues relating to Python 3.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants