autoSubscribe: only stop subscriptions if the arguments change #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a simple usage of
autoSubscribesuch as:Currently, each time the
routechanges/invalidates, even if theroute.params.iddoes not change, it will send an "unsub" and "sub" message to the meteor server. Causing the publication to be re-run on the server using additional (unnecessary) resources.The solution is to copy the pattern from the built-in
meteor/ddp-clientsubscribe function, where it integrates withTracker.Here is the relevant code:
This pull request attempts to approximate
Tracker.afterFlushby usingPromise.resolve(); I'm not aware if there's a better method for vue reactivity.