test(workflows/build): enable cibuildwheel test for iOS simulator and Android #247
Conversation
XuehaiPan
added
integration
There was a problem hiding this comment.
Pull Request Overview
This PR enables cibuildwheel testing for iOS simulator and Android platforms by removing skip test configurations. The purpose is to allow automated testing on these mobile platforms during the build process.
- Removes test skipping for Android builds
- Removes test skipping for iOS simulator builds
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
As it says in the cibuildwheel documentation, the only GitHub Actions runner that can run the Android emulator is Linux x86_64. So I recommend you do your Android builds on that, and add x86_64 to the architecture list so you can run tests on at least one of them. Releasing Android x86_64 wheels will also be useful to the large number of Android developers who test their apps on x86_64 emulators. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1416 1416
Branches 175 175
=========================================
Hits 1416 1416 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The Android Python 3.14 failure will be fixed by pypa/cibuildwheel#2590. It should also be possible to work around by going back to cibuildwheel version 3.2.0. |
XuehaiPan
force-pushed
the
enable-ios-android-tests
branch
5 times, most recently
from
28d240c to
bddc423
Compare
XuehaiPan
force-pushed
the
enable-ios-android-tests
branch
from
bddc423 to
f660125
Compare
This has now been released in cibuildwheel 3.3.0. |
2 participants
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213I have raised an issue to propose this change (required for new features and bug fixes)
Update Android test-command handling pypa/cibuildwheel#2590
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)