Skip to content

SEARCH-690 (writer): Add artist credit MBID to output #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Dec 3, 2022

Problem: SEARCH-690 (writer part)

Search server doesn’t include MBID in results for search indexes (recording, release, release-group) that have artist credit.

Solution

  • Switch mmd-schema used to write the results to an (upcoming) version that includes artist credit MBID;
  • Add id attribute to artist-credit XML element.
  • Update XML and JSON tests accordingly

Todolist before merging

Action after merging

  1. Release and deploy
  2. After rebuilding indexes with SEARCH-690 (indexer): Add artist credit MBID in indexes sir#157,
    make the updated WikiDocs page visible on MusicBrainz website

@yvanzo yvanzo marked this pull request as ready for review December 5, 2022 16:19
@yvanzo yvanzo force-pushed the search-690 branch 2 times, most recently from d720cf0 to 8673242 Compare April 28, 2025 16:21
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvanzo
Copy link
Contributor Author

yvanzo commented May 18, 2025

Retested with the examples from the twin pull request to the sir repository.

@yvanzo yvanzo merged commit ee3d853 into master May 18, 2025
1 check passed
@yvanzo yvanzo deleted the search-690 branch May 18, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants