correctly set log level for benchmark runs #3494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # context * loglevel is not correctly set in train pipeline benchmark due to the multiprocess setup * the log level is only set in the main process but not correctly set in the forked/spawn processes * this diff add the `loglevel` argument into the RunConfig so that in every runner funcion can call `set_logger_level` * also directly pass the error message on yaml or json parser failure, which previously just warn silently and the warning message is buried in lengthy logs. Differential Revision: D85829837
Contributor
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85829837. |
meta-cla
bot
added
the
CLA Signed
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Nov 2, 2025
Summary: # context * loglevel is not correctly set in train pipeline benchmark due to the multiprocess setup * the log level is only set in the main process but not correctly set in the forked/spawn processes * this diff add the `loglevel` argument into the RunConfig so that in every runner funcion can call `set_logger_level` * also directly pass the error message on yaml or json parser failure, which previously just warn silently and the warning message is buried in lengthy logs. * with loglevel=info we can now see the planner info: P2014482201 Differential Revision: D85829837
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Nov 2, 2025
Summary: # context * loglevel is not correctly set in train pipeline benchmark due to the multiprocess setup * the log level is only set in the main process but not correctly set in the forked/spawn processes * this diff add the `loglevel` argument into the RunConfig so that in every runner funcion can call `set_logger_level` * also directly pass the error message on yaml or json parser failure, which previously just warn silently and the warning message is buried in lengthy logs. * with loglevel=info we can now see the planner info: P2014482201 Differential Revision: D85829837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
loglevelargument into the RunConfig so that in every runner funcion can callset_logger_levelDifferential Revision: D85829837