Skip to content

Conversation

@NicolasHug
Copy link
Contributor

We currently expose the "FFmpeg" CUDA interface as set_cuda_backend("ffmpeg"). But in private code, we're still referring to it as the "default" interface, which is what we used to call it.

This PR renames all uses of "default" into "ffmpeg". This is more consistent with what we publicly expose, and also makes sense since the "default" behavior of the Interface base class is to dispatch to FFmpeg (once #954 is merged).

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 15, 2025
@NicolasHug NicolasHug marked this pull request as draft October 15, 2025 12:55
@NicolasHug NicolasHug marked this pull request as ready for review October 15, 2025 13:43
@NicolasHug NicolasHug merged commit b9cf8d1 into meta-pytorch:main Oct 15, 2025
23 checks passed
@NicolasHug NicolasHug deleted the renamedefaultintobeta branch October 15, 2025 15:19
NicolasHug added a commit to NicolasHug/torchcodec that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants