Skip to content

Refactor CudaDeviceInterface::getCudaContext #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2025
Merged

Refactor CudaDeviceInterface::getCudaContext #956

merged 6 commits into from
Oct 15, 2025

Conversation

@mollyxu
Copy link
Contributor

@mollyxu mollyxu commented Oct 13, 2025 •
edited
Loading

Refactor CudaDeviceInterface::getCudaContext to CudaDeviceInterface::getHardwareDeviceContext and removed duplicate code.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 13, 2025
scotts
scotts reviewed Oct 14, 2025
View reviewed changes
scotts
scotts reviewed Oct 14, 2025
View reviewed changes
scotts
scotts reviewed Oct 14, 2025
View reviewed changes
@mollyxu mollyxu marked this pull request as ready for review October 14, 2025 20:40
scotts
scotts reviewed Oct 14, 2025
View reviewed changes
scotts
scotts approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@scotts scotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mollyxu, thank you, this is much cleaner! :)

@NicolasHug
Copy link
Contributor

NicolasHug commented Oct 15, 2025

Thanks @mollyxu , I'll land this now to avoid merge conflicts as I'm working on #960 which is touching the same parts of the code base.

@NicolasHug NicolasHug merged commit 48b07cc into meta-pytorch:main Oct 15, 2025
53 of 54 checks passed
@mollyxu
Copy link
Contributor Author

mollyxu commented Oct 17, 2025

addressed #924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotts scotts scotts approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mollyxu @NicolasHug @scotts