Fix internal linter #940
Merged
Fix internal linter #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Oct 8, 2025
Comment on lines
+35
to
+36
| DeviceInterfaceKey(torch::DeviceType type, const std::string_view& variant) | ||
| : deviceType(type), variant(variant) {} |
Contributor
Author
There was a problem hiding this comment.
Internal linter is complaining that we're doing
DeviceInterfaceKey(torch::kCUDA, /*variant=*/"beta"),and that our /*variant=*/ comment doesn't match the name of the parameter which is var.
I'm choosing to change the parameter name to from var to variant, instead of updating the comment: we use "variant" everywhere. "var" was only used for the initialization list not to look like variant(variant), which ... it does now. 🤷♂️
Dan-Flores
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.