Update tokenizers-config for Windows #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
JacobSzwejbka
approved these changes
Sep 25, 2025
GregoryComer
force-pushed
the
fix-config-windows
branch
from
dc9b160 to
bc989c1
Compare
larryliu0820
approved these changes
Sep 25, 2025
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D83367882. |
|
I'm getting an error when trying to merge - "Required status check "Meta Internal-Only Changes Check" was not set by the expected GitHub app." Will try importing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokenizers-config CMake file needs to be updated to use the .lib extension on Windows, instead of .a, for the tokenizers library. This allows tokenizers to be referenced via find_package on Windows. This was an oversight in #121.