[hyperactor] ensure that the host agent is always ready when serving a host; remove execution URL #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a host; remove execution URL Ensure that a host agent is always ready when serving a host. Currently, we serve the channel -- making the address available -- and *then* launch the agent. Thus, there is a small race condition where we could receive messages on the channel without the agent being available. Starting Meta binaries is already slow, and the execution URL adds to it. We also remove this to speed startup. Differential Revision: [D88208166](https://our.internmc.facebook.com/intern/diff/D88208166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88208166/)! [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
This was referenced Dec 1, 2025
…en serving a host; remove execution URL" Ensure that a host agent is always ready when serving a host. Currently, we serve the channel -- making the address available -- and *then* launch the agent. Thus, there is a small race condition where we could receive messages on the channel without the agent being available. Starting Meta binaries is already slow, and the execution URL adds to it. We also remove this to speed startup. Differential Revision: [D88208166](https://our.internmc.facebook.com/intern/diff/D88208166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88208166/)! [ghstack-poisoned]
…en serving a host; remove execution URL" Ensure that a host agent is always ready when serving a host. Currently, we serve the channel -- making the address available -- and *then* launch the agent. Thus, there is a small race condition where we could receive messages on the channel without the agent being available. Starting Meta binaries is already slow, and the execution URL adds to it. We also remove this to speed startup. Differential Revision: [D88208166](https://our.internmc.facebook.com/intern/diff/D88208166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88208166/)! [ghstack-poisoned]
|
This pull request has been merged in eb00c95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
spawnsync #1968newfrom actor #1962Ensure that a host agent is always ready when serving a host. Currently, we serve the channel -- making the address available -- and then launch the agent. Thus, there is a small race condition where we could receive messages on the channel without the agent being available.
Starting Meta binaries is already slow, and the execution URL adds to it. We also remove this to speed startup.
Differential Revision: D88208166
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!